Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch interchange as a fresh process #3463

Merged
merged 20 commits into from
Jun 14, 2024
Merged

Commits on May 28, 2024

  1. fiddle with interchange default values

    there are default values in the interchange code, but they are all specified in the executor code too, so these defautls will
    never be used. remove them as misleading.
    
    see similar changes to process worker pool, PR #2973, for more detailed justification
    
    needs to change zmq sockets test because that assumes the arbitrary defaults are present.
    which is no longer the case.
    but if you want to initialize an interchange that requires you to specify all this stuff, and want some arbitrary values,
    then make those arbitrary values yourself.
    
    client address parameter is now supplied by the executor - it was not before, and so the default/hard-coded value
    now lives in the executor, not the interchange
    benclifford committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f56c92c View commit details
    Browse the repository at this point in the history
  2. make interchange into a "first-order" process like process worker poo…

    …l, not multiprocessing
    
    any downstream packaging will need to be aware of the presence of interchange.py as a new command-line invocable script
    and this might break some build instructions which do not configure installed scripts onto the path.
    
    this PR replaces keyword arguments with argparse command line parameters. it does not attempt to make those
    command line arguments differently-optional than the constructor of the Interchange class (for example, worker_ports and
    worker_port_range are both mandatory, because they are both specified before this PR)
    
    i'm somewhat uncomfortable with this seeming like an ad-hoc serialise/deserialise protocol for what was previously
    effecting a dict of typed python objects... but it's what process worker pool does.
    
    see issue #3373 for interchange specific issue
    
    see issue #2343 for parsl general fork vs threads issue
    
    see possibly issue #3378?
    benclifford committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1733deb View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    50d70e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    cf9eebb View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    d762aaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed6fae5 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    10c02fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e59ceb View commit details
    Browse the repository at this point in the history
  3. isort

    benclifford committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4a60874 View commit details
    Browse the repository at this point in the history
  4. Add broken test comment

    benclifford committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    cd2d879 View commit details
    Browse the repository at this point in the history
  5. Update mock to I think documented Popen behaviour, and fix shutdown b…

    …ehaviour to pass. Not tested against a real hanging interchange though...
    benclifford committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0de296b View commit details
    Browse the repository at this point in the history
  6. Rename variable

    benclifford committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    83f15ad View commit details
    Browse the repository at this point in the history
  7. Remove commented-out code

    benclifford committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0de37c4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ae9806d View commit details
    Browse the repository at this point in the history
  9. Rename some parsers

    benclifford committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d07ad3a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2c47762 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    853d12a View commit details
    Browse the repository at this point in the history
  12. 1 Configuration menu
    Copy the full SHA
    e7d18aa View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    e611582 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    7f4b7dd View commit details
    Browse the repository at this point in the history