-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch interchange as a fresh process #3463
Merged
Merged
Commits on May 28, 2024
-
fiddle with interchange default values
there are default values in the interchange code, but they are all specified in the executor code too, so these defautls will never be used. remove them as misleading. see similar changes to process worker pool, PR #2973, for more detailed justification needs to change zmq sockets test because that assumes the arbitrary defaults are present. which is no longer the case. but if you want to initialize an interchange that requires you to specify all this stuff, and want some arbitrary values, then make those arbitrary values yourself. client address parameter is now supplied by the executor - it was not before, and so the default/hard-coded value now lives in the executor, not the interchange
Configuration menu - View commit details
-
Copy full SHA for f56c92c - Browse repository at this point
Copy the full SHA f56c92cView commit details -
make interchange into a "first-order" process like process worker poo…
…l, not multiprocessing any downstream packaging will need to be aware of the presence of interchange.py as a new command-line invocable script and this might break some build instructions which do not configure installed scripts onto the path. this PR replaces keyword arguments with argparse command line parameters. it does not attempt to make those command line arguments differently-optional than the constructor of the Interchange class (for example, worker_ports and worker_port_range are both mandatory, because they are both specified before this PR) i'm somewhat uncomfortable with this seeming like an ad-hoc serialise/deserialise protocol for what was previously effecting a dict of typed python objects... but it's what process worker pool does. see issue #3373 for interchange specific issue see issue #2343 for parsl general fork vs threads issue see possibly issue #3378?
Configuration menu - View commit details
-
Copy full SHA for 1733deb - Browse repository at this point
Copy the full SHA 1733debView commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 50d70e7 - Browse repository at this point
Copy the full SHA 50d70e7View commit details
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf9eebb - Browse repository at this point
Copy the full SHA cf9eebbView commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d762aaf - Browse repository at this point
Copy the full SHA d762aafView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6fae5 - Browse repository at this point
Copy the full SHA ed6fae5View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 10c02fe - Browse repository at this point
Copy the full SHA 10c02feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e59ceb - Browse repository at this point
Copy the full SHA 8e59cebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a60874 - Browse repository at this point
Copy the full SHA 4a60874View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd2d879 - Browse repository at this point
Copy the full SHA cd2d879View commit details -
Update mock to I think documented Popen behaviour, and fix shutdown b…
…ehaviour to pass. Not tested against a real hanging interchange though...
Configuration menu - View commit details
-
Copy full SHA for 0de296b - Browse repository at this point
Copy the full SHA 0de296bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83f15ad - Browse repository at this point
Copy the full SHA 83f15adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0de37c4 - Browse repository at this point
Copy the full SHA 0de37c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae9806d - Browse repository at this point
Copy the full SHA ae9806dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d07ad3a - Browse repository at this point
Copy the full SHA d07ad3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c47762 - Browse repository at this point
Copy the full SHA 2c47762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 853d12a - Browse repository at this point
Copy the full SHA 853d12aView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e7d18aa - Browse repository at this point
Copy the full SHA e7d18aaView commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e611582 - Browse repository at this point
Copy the full SHA e611582View commit details
Commits on Jun 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7f4b7dd - Browse repository at this point
Copy the full SHA 7f4b7ddView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.