Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Youtube Icon #13

Closed
wants to merge 5 commits into from
Closed

Conversation

yashrsharma44
Copy link
Contributor

@yashrsharma44 yashrsharma44 commented Dec 16, 2017

Actually I made a PR from master, so made a PR from non-master branch.

@Parth-Vader
Copy link
Owner

Looks cool. Can you also make the links clickable instead of the text?

@yashrsharma44
Copy link
Contributor Author

Okay. But I have to make a Seperate PR as it needs to include the recent commit #11

@Parth-Vader
Copy link
Owner

git pull and add to this PR itself.

@yashrsharma44
Copy link
Contributor Author

Thanks.

@yashrsharma44
Copy link
Contributor Author

Added the Hyperlink for the Videos.

@yashrsharma44
Copy link
Contributor Author

Can you close this PR, if everything is fine?

@Parth-Vader
Copy link
Owner

@yashrsharma44 Why do you want to close this PR? Do you not want this to be merged?

I tested it - but the Click To Open link doesn't seem to work.

@yashrsharma44
Copy link
Contributor Author

Sorry for that. I need to address some issues regarding the link, so I will correct it now.

@yashrsharma44
Copy link
Contributor Author

I am not able to save the changes in this PR, so I need to close this PR and make a new PR. Please consider that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants