Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Preparation using LightningDataModule #4

Open
9 of 17 tasks
Tracked by #3
ParthaPratimBanik opened this issue Aug 20, 2023 · 0 comments
Open
9 of 17 tasks
Tracked by #3

Data Preparation using LightningDataModule #4

ParthaPratimBanik opened this issue Aug 20, 2023 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ParthaPratimBanik
Copy link
Owner

ParthaPratimBanik commented Aug 20, 2023

Have to implement the following things by using torch.utils.data.Dataset:

  • def __init__(...): Setup data directory
  • def __len__(...): Return the length of sample
  • def __getitem__(...): Return the sample (x, y)

    Have to Implement the following things by using LightningDataModule, for the inj_cora dataset:
  • def __init__(...): setup data directory
  • def preapre_data(...): download data in local
  • def setup(...): load data from local
  • def train_dataloaders(...): setup training data for training
  • Must be equal or close to load_data() result for inj_cora dataset

    Dataset preparations depend on the following functions and variables:
  1. to_dense_adj(...)
  2. num_neigh + num_layers
  3. NeighborLoader(...)

    The above factors are dependent on models. So, have to do the following things:
  • Point out models with to_dense_adj(...) and/or num_neigh + num_layers and NeighborLoader(...)


Have to do the following things, based on the above implementations:

  • Comparing the output of the following datasets with the load_data() output:
    • inj_amazon
    • inj_flickr
    • weibo
    • reddit
    • disney
    • books
    • enron
@ParthaPratimBanik ParthaPratimBanik mentioned this issue Aug 20, 2023
4 tasks
@ParthaPratimBanik ParthaPratimBanik changed the title Data Preparation using Data Preparation using LightningDataModule Aug 20, 2023
@ParthaPratimBanik ParthaPratimBanik self-assigned this Aug 20, 2023
@ParthaPratimBanik ParthaPratimBanik added the good first issue Good for newcomers label Aug 20, 2023
ParthaPratimBanik added a commit that referenced this issue Aug 20, 2023
ParthaPratimBanik added a commit that referenced this issue Aug 22, 2023
Partially Fixed Issue #4 

- updated dataset.py for all models

Dataset preparations depend on the following functions and variables:
1. `to_dense_adj(...)`
2. `num_neigh` + `num_layers`
3. `NeighborLoader(...)`\
\
The above factors are dependent on models. So, have to do the following things:
- [x] Point out models with `to_dense_adj(...)` and/or `num_neigh` + `num_layers` and `NeighborLoader(...)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant