-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for NServiceBus.TransactionalSession 1.0.0 #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
requested review from
SzymonPobiega,
tmasternak,
lailabougria and
timbussmann
September 7, 2022 12:37
danielmarbach
changed the title
[WIP] Implement TransactionalSession as part of the persistence
Implement TransactionalSession as part of the persistence
Sep 12, 2022
SzymonPobiega
approved these changes
Sep 12, 2022
tmasternak
approved these changes
Sep 12, 2022
timbussmann
reviewed
Sep 13, 2022
src/NServiceBus.Persistence.AzureTable.TransactionalSession/AzureTableOpenSessionOptions.cs
Outdated
Show resolved
Hide resolved
timbussmann
approved these changes
Sep 13, 2022
Will rebase |
* add editorconfig files * remove ref to coderules package * switch to NServiceBusTests.snk * remove custom suppressions * update InternalsVisibleTo * use default analyzer version * update tests to new safa config APIs * rename CancellationToken parameter to resolve analyzer warning * add missing .globalconfig * remove workaround files * Load persistence assembly * Remove unneeded files Co-authored-by: danielmarbach <daniel.marbach@openplace.net>
* Implement TransactionalSession as part of the persistence * Make transactional session part of the persistence seam * ApiApprovals * Add TransactionalSession to scanning too * Update src/NServiceBus.Persistence.AzureTable.TransactionalSession/AzureTableOpenSessionOptions.cs Co-authored-by: Tomasz Masternak <tomasz.masternak@particular.net> * Beta5 * Move towards making tx session atts its own concept * Activate base feature too * Include missing files 🤦 * Remove redundant code * Adjust to latest transactional session changes * Take an explicit dependency * Bump RC3 * Calling base setup Co-authored-by: Tomasz Masternak <tomasz.masternak@particular.net>
danielmarbach
force-pushed
the
transactional-session-v7
branch
from
September 13, 2022 09:51
80d7f90
to
7f26c04
Compare
danielmarbach
changed the title
Implement TransactionalSession as part of the persistence
Support for NServiceBus.TransactionalSession 1.0.0
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.