Audit queue incorrectly created on send-only endpoint #6740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bording
approved these changes
May 24, 2023
DavidBoike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the NServiceBus 8 transport seam treat all queues the same and pass them as a collection to the transport, and transports create them. Becuase the Audit feature was not dependent upon whether the endpoint was send-only, this means that the audit queue was also being created, as well as other unnecessary stuff like the diagnostics entry, logging, and adding behaviors to the receive pipeline.
This PR adds a prerequisite so that the Audit feature will not run if the endpoint is send only.
This is a fix for #6736.