Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow outbox to be enabled for send only endpoints via an explicit opt-in setting #6750

Merged
merged 9 commits into from Jun 8, 2023

Conversation

andreasohlund
Copy link
Member

@andreasohlund andreasohlund commented Jun 4, 2023

Allows Particular/NServiceBus.TransactionalSession#96 to be implemented in the future.

@andreasohlund andreasohlund added this to the 8.1.0 milestone Jun 5, 2023
@andreasohlund
Copy link
Member Author

@danielmarbach should we enable sagas as well? https://github.com/Particular/NServiceBus/blob/master/src/NServiceBus.Core/Sagas/Sagas.cs#L33

The more I think about this I feel that both the outbox and sagas should depend on the storage session being enabled and that one in turn should look at send only or not?

@danielmarbach
Copy link
Contributor

As far as I recall, synchronized storage is always enabled when either outbox or saga are activated because it is required to setup the DI part too.

should we enable sagas as well?

I see no benefit for a sendonly endpoint to do that. You?

@andreasohlund
Copy link
Member Author

I see no benefit for a sendonly endpoint to do that. You?

Yea, since you need to receive messages (currently) in order to interact with sagas

@andreasohlund andreasohlund marked this pull request as ready for review June 8, 2023 08:02
@andreasohlund
Copy link
Member Author

I've verified that this works for SQLP by adding the override and seeing that a send only endpoint is able to get data into the outbox table

@DavidBoike
Copy link
Member

Given I just fixed the Audit behavior for send-only endpoints in #6740, are there any knock-on effects to having the Outbox run in https://github.com/Particular/NServiceBus/blob/master/src/NServiceBus.Core/Audit/Audit.cs#L19-L20 that should be considered? The endpoint is still send-only, not receiving messages, and therefore not creating an audit queue, so all is good, right?

@andreasohlund
Copy link
Member Author

The endpoint is still send-only, not receiving messages, and therefore not creating an audit queue, so all is good, right?

Yea

@andreasohlund andreasohlund changed the title Add setting to force outbox enabled for send only endpoints Allow outbox to be enabled for send only endpoints via an explicit opt-in setting Jun 8, 2023
@andreasohlund andreasohlund merged commit e285dc1 into master Jun 8, 2023
3 checks passed
@andreasohlund andreasohlund deleted the outbox-sendonly branch June 8, 2023 13:52
@danielmarbach
Copy link
Contributor

😎👍Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants