Fixing upgrade for audit instance and bring in platform package sample fix #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing upgrade for audit instance 1. Added a new command called "UpgradeAuditInstanceCommand" 2. Wired the command in the InstanceDetailsViewModel. TODO: - Need to test this change. * Update src/ServiceControl.Config/Commands/UpgradeAuditInstanceCommand.cs fixed the message acc to Ramon's suggestion. Co-Authored-By: Ramon Smits <ramon.smits@gmail.com> * Update src/ServiceControl.Config/Commands/UpgradeAuditInstanceCommand.cs fix the message acc to Ramon's suggestion Co-Authored-By: Ramon Smits <ramon.smits@gmail.com> * Aligned proceed message * Aligned update command * Cleanup * Reduce nesting
ramonsmits
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1737