Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small validation bugs #4046

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Fix small validation bugs #4046

merged 5 commits into from
Apr 5, 2024

Conversation

WilliamBZA
Copy link
Member

Fixes #3999
Fixes not allowing the user to select paths

Copy link
Contributor

@PhilBastian PhilBastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

@WilliamBZA
Copy link
Member Author

Tests added @PhilBastian

@mikeminutillo mikeminutillo merged commit a464ec2 into master Apr 5, 2024
19 checks passed
@mikeminutillo mikeminutillo deleted the validation-fixes branch April 5, 2024 06:12
mikeminutillo added a commit that referenced this pull request Apr 5, 2024
* Allow propogation of propertychange events

* Prevent event bubbling

* Switch back to invalid file chars

* Add notify propogation tests

* Add file path sanitization tests

---------

Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
mikeminutillo added a commit that referenced this pull request Apr 8, 2024
* Diagnostic improvements and bulk insert time config setting (#4049)

* Add exception logging to DomainEvents

* Add NServiceBus reference

* Add debug logging to EndpointInstanceMonitor

* Add configurable bulk insert timeout

---------

Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com>

* Remove audit queue validation checks (#4048)

* Fix small validation bugs (#4046)

* Allow propogation of propertychange events

* Prevent event bubbling

* Switch back to invalid file chars

* Add notify propogation tests

* Add file path sanitization tests

---------

Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>

* Fix test for primary instance convention default

Original commit is here 84f61ec

* RavenDb License refresh

---------

Co-authored-by: Szymon Pobiega <szymon.pobiega@gmail.com>
Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com>
Co-authored-by: John Simons <john.simons@particular.net>
@danielmarbach
Copy link
Contributor

I have raised an improvement issue #4127
Wiring up the validation has caused the UI to become quite sluggish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking whitespace in the ServiceControl Management Utility unchecks the instance type checkbox
5 participants