-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small validation bugs #4046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilBastian
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests?
Tests added @PhilBastian |
PhilBastian
approved these changes
Apr 2, 2024
mikeminutillo
approved these changes
Apr 3, 2024
SzymonPobiega
approved these changes
Apr 3, 2024
mikeminutillo
added a commit
that referenced
this pull request
Apr 5, 2024
* Allow propogation of propertychange events * Prevent event bubbling * Switch back to invalid file chars * Add notify propogation tests * Add file path sanitization tests --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
Merged
mikeminutillo
added a commit
that referenced
this pull request
Apr 8, 2024
* Diagnostic improvements and bulk insert time config setting (#4049) * Add exception logging to DomainEvents * Add NServiceBus reference * Add debug logging to EndpointInstanceMonitor * Add configurable bulk insert timeout --------- Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com> * Remove audit queue validation checks (#4048) * Fix small validation bugs (#4046) * Allow propogation of propertychange events * Prevent event bubbling * Switch back to invalid file chars * Add notify propogation tests * Add file path sanitization tests --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net> * Fix test for primary instance convention default Original commit is here 84f61ec * RavenDb License refresh --------- Co-authored-by: Szymon Pobiega <szymon.pobiega@gmail.com> Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com> Co-authored-by: John Simons <john.simons@particular.net>
I have raised an improvement issue #4127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3999
Fixes not allowing the user to select paths