Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to a different ServiceControl instance does not refresh views #574

Closed
fafachd opened this issue Mar 30, 2016 · 9 comments · Fixed by #626
Closed

Connecting to a different ServiceControl instance does not refresh views #574

fafachd opened this issue Mar 30, 2016 · 9 comments · Fixed by #626
Assignees
Labels
Milestone

Comments

@fafachd
Copy link

fafachd commented Mar 30, 2016

v1.5.6

Connecting to a different ServiceControl instance DOES NOTHING (until ServiceInsight is restarted or refreshed). This results in a bad user experience when switching between Dev, Test, and Prod, environments:

  1. User connects to a different SC instance and clicks OK.
  2. User waits a long time for the change to take effect.
  3. User eventually gives up waiting and restarts SI or clicks Refresh.

Please fix this. You could alternatively update the "Connect to ServiceControl" dialog to say something like: "You must click Refresh for this change to take effect", but that sure feels like a hack.

Thank you,
Danny

@robinbihun
Copy link

Additional Info - it appears that the connection does refresh, but the UI does not refresh until you click an element (or the new server) in the endpoint explorer pane on the left. This could probably be resolved by setting the selectedindex to the newly connected instance; however, I would rather see the endpoint explorer behave more like SSMS in that it will show me all the servers it's connected to with the ability to drill down into specific ones to view the queues.

@HEskandari
Copy link
Contributor

Thanks for reporting this. I'll mark this as a bug and we address the issue @fafachd reported and open another feature request for supporting multiple endpoints in the Endpoint Explorer.

Would that work?

@robinbihun
Copy link

@HEskandari Sounds great to me!

@fafachd
Copy link
Author

fafachd commented Mar 31, 2016

Perfect, thank you @HEskandari.

@HEskandari
Copy link
Contributor

Just verified in v1.5.7 and it is still reproducible and is not fixed.

@adamralph
Copy link
Member

#575 has been partially implemented which means we cannot verify whether this has been fixed in master. We will feature toggle the partial implementation off and then verify whether this has been fixed on master.

@distantcam distantcam added this to the 1.6.0 milestone Oct 27, 2016
@distantcam distantcam assigned distantcam and unassigned HEskandari Nov 2, 2016
@adamralph adamralph modified the milestones: Future, 1.5.8 Nov 3, 2016
@adamralph
Copy link
Member

Since we are reopening closed bugs on the 1.5.8 milestone due to reverting master to 1.5.7 in #617, this issue has been moved from the 1.5.8 milestone to the Future milestone, to make a distinction.

This may be re-added to the 1.5.8 milestone if we decide to fix it before releasing 1.5.8.

HEskandari added a commit that referenced this issue Nov 10, 2016
- Raising an event when connection to SC changes
- Clearing the message body views
- Clearing the saga view
- Clearing messages window.
@HEskandari HEskandari removed this from the Future milestone Nov 15, 2016
adamralph added a commit that referenced this issue Nov 15, 2016
@adamralph adamralph added this to the 1.5.9 milestone Nov 15, 2016
@adamralph
Copy link
Member

This fix will be in the next release.

@adamralph
Copy link
Member

Thanks to @fafachd for raising this.

@adamralph adamralph changed the title Connecting to Different Service Control Instance Does Nothing Connecting to a different ServiceControl instance does not refresh views Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants