Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed experimental icon from queue length headers #633

Merged
merged 2 commits into from May 23, 2018

Conversation

tmasternak
Copy link
Member

This is part of Native Queue length implementation. Native ql is not experimental anymore.

@tmasternak tmasternak requested a review from a team May 22, 2018 06:42
@@ -54,13 +54,7 @@ <h1>
<div class="col-sm-12 no-side-padding graph-values">
<div class="row queue-length-values tooltip-trigger">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you also remove the link inside the tootltip, then remove the class tooltip-trigger and use a standard tooltip attribute for the metric explanation.

@@ -28,14 +28,7 @@ <h1>Endpoints overview</h1>
<div class="row box-header">
<div class="col-sm-12 no-side-padding">
<div class="tooltip-trigger">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you also remove the link inside the tootltip, then remove the class tooltip-trigger and use a standard tooltip attribute for the metric explanation.

@mikeminutillo mikeminutillo added this to the 1.13.4 milestone May 23, 2018
@mikeminutillo mikeminutillo added the Type: Improvement Type: Improvement label May 23, 2018
@mikeminutillo mikeminutillo changed the title Removing experimental icon from queue length headers Remove experimental icon from queue length headers May 23, 2018
@mikeminutillo mikeminutillo changed the title Remove experimental icon from queue length headers Removed experimental icon from queue length headers May 23, 2018
@mikeminutillo mikeminutillo merged commit 1183690 into master May 23, 2018
@tmasternak tmasternak added Type: Feature Type: Feature and removed Type: Improvement Type: Improvement labels May 23, 2018
@WojcikMike WojcikMike deleted the ql-no-longer-experimental branch May 23, 2018 10:39
WilliamBZA pushed a commit that referenced this pull request Feb 17, 2023
Removed experimental icon from queue length headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants