Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed experimental icon from queue length headers #633

Merged
merged 2 commits into from May 23, 2018
Merged

Removed experimental icon from queue length headers #633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95c0210
removing experimental icon from queue length
tmasternak May 22, 2018
fe61f0c
Use standard tooltips
mikeminutillo May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/ServicePulse.Host/app/modules/monitoring/views/endpoint_details.html
View file
Open in desktop
Expand Up @@ -54,13 +54,7 @@ <h1>
<div class="col-sm-12 no-side-padding graph-values">
<div class="row queue-length-values tooltip-trigger">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you also remove the link inside the tootltip, then remove the class tooltip-trigger and use a standard tooltip attribute for the metric explanation.

<div class="metric-digest-header">
Queue Length <i class="fa fa-flask fake-link"></i>
</div>
<div class="interactive-tooltip">
<div class="tooltip-contents">
<p>Queue length: The estimated number of messages in an endpoint's queue.</p>
<p>NOTE: This is an experimental feature. <a href="https://docs.particular.net/monitoring/metrics/definitions#metrics-captured-queue-length-known-limitations" target="_blank">Learn more</a> <i class="fa fa-external-link fake-link"></i></p>
</div>
Queue Length
</div>
</div>
<div class="row metric-digest-value current">
Expand Down
9 changes: 1 addition & 8 deletions src/ServicePulse.Host/app/modules/monitoring/views/monitored_endpoints.html
View file
Open in desktop
Expand Up @@ -28,14 +28,7 @@ <h1>Endpoints overview</h1>
<div class="row box-header">
<div class="col-sm-12 no-side-padding">
<div class="tooltip-trigger">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you also remove the link inside the tootltip, then remove the class tooltip-trigger and use a standard tooltip attribute for the metric explanation.

Queue Length <span class="table-header-unit">(msgs)</span> <i class="fa fa-flask fake-link"></i>
<div class="interactive-tooltip">
<div class="tooltip-contents">
<p>Queue length: The estimated number of messages in an endpoint's queue.</p>
<p>WARNING: This is an experimental feature. <a href="https://docs.particular.net/monitoring/metrics/definitions#metrics-captured-queue-length-known-limitations" target="_blank">Learn more</a> <i class="fa fa-external-link fake-link"></i>
</p>
</div>
</div>
Queue Length <span class="table-header-unit">(msgs)</span>
</div>
</div>
</div>
Expand Down