fix(js): propagate error from child process to @nx/js:node executor (n…

…rwl#22705)
Pascalmh · Apr 5, 2024 · a9e554f · a9e554f
1 parent 8a9e2fd
commit a9e554f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/e2e/js/src/js-executor-node.test.ts b/e2e/js/src/js-executor-node.test.ts
@@ -44,6 +44,7 @@ describe('js:node executor', () => {
 
     const output = runCLI(`run ${esbuildLib}:run-node`, {
       redirectStderr: true,
+      silenceError: true,
     });
     expect(output).toContain('Hello from my library!');
     expect(output).toContain('This is an error');

diff --git a/packages/js/src/executors/node/node.impl.ts b/packages/js/src/executors/node/node.impl.ts
@@ -175,7 +175,13 @@ export async function* nodeExecutor(
                   `NX Process exited with code ${code}, waiting for changes to restart...`
                 );
               }
-              if (!options.watch) done();
+              if (!options.watch) {
+                if (code !== 0) {
+                  error(new Error(`Process exited with code ${code}`));
+                } else {
+                  done();
+                }
+              }
               resolve();
             });