Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @babel/types #28

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Conversation

sakai-akinobu
Copy link
Contributor

Thank you for a nice module! I'm using it conveniently.

Babel v7.0.0-beta.48 it seems that the argument has been changed to objectTypeAnnotation of babel/types.
babel/babel#7947

#27 Perhaps this issue is probably related to this change.

So I am glad that you will merge this fix.

@sakai-akinobu
Copy link
Contributor Author

@wmonk Babel 7 was released, so I fixed it again.
In order to solve #27, I want to merge this pull request. How about it?

@apalm
Copy link

apalm commented Sep 12, 2018

Can this please be merged? 🙏 As @sakai-akinobu points out, the signature of objectTypeAnnotation has changed, and since the version of @babel/types used by this package isn't pinned, it's possible for versions >= 7.0.0-beta.48 to be installed, and causes #27.

screen shot 2018-09-12 at 14 25 54

@arahansen
Copy link

Just ran into this myself, would love to see this merged!

@wmonk wmonk merged commit fc2c872 into PassFort:master Oct 19, 2018
@wmonk
Copy link
Contributor

wmonk commented Oct 19, 2018

Released in @1.0.0

@sakai-akinobu
Copy link
Contributor Author

Thank you for taking the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants