Update tsconfig for ts 4.0 #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledustet
reviewed
Sep 28, 2020
tsconfig.json
Outdated
| "jest/*", | ||
| "**/*.svg" | ||
| ] | ||
| "include": ["src/**/*", "App.tsx", "**/*.d.ts"], |
There was a problem hiding this comment.
curious why the root folder is not included?
There was a problem hiding this comment.
I suppose because src/ and App.tsx are the only ts files? but no reason to not have it be the root, we will update!
aledustet
approved these changes
Sep 28, 2020
johnschoeman
force-pushed
the
jts-dj-update-tsconfig
branch
2 times, most recently
from
8b57423
to
5bd659b
Compare
aledustet
reviewed
Sep 28, 2020
tsconfig.json
Outdated
| "jest/*", | ||
| "**/*.svg" | ||
| ] | ||
| "include": ["**/*.ts", "**/*.d.ts"], |
There was a problem hiding this comment.
should we have the tsx files here too?
There was a problem hiding this comment.
I believe it works for tsx if we use ts but it might be good to add tsx to be exhaustive?
There was a problem hiding this comment.
They are captured!
johnschoeman
force-pushed
the
jts-dj-update-tsconfig
branch
from
5bd659b
to
ae82aa1
Compare
Why: Currently our tsconfig is set to only run the ts compiler on files that end with `.d.ts` which means that the complier is not running on any of our source files. This was caused by an update to the behaviour of the includes tsconfig option from being inclusive to exclusive. This commit: updates the tsconfig file to fix the issue as well as removes no no longer necessary config options. We updated some type errors that made their way into the codebase during the few days of not type checking the entire codebase Co-Authored-By: devin jameson <devin@thoughtbot.com>
johnschoeman
force-pushed
the
jts-dj-update-tsconfig
branch
from
ae82aa1
to
451cccd
Compare
tokumori
pushed a commit
to AlohaSafe/gaen-mobile
that referenced
this pull request
Oct 1, 2020
Why: Currently our tsconfig is set to only run the ts compiler on files that end with `.d.ts` which means that the complier is not running on any of our source files. This was caused by an update to the behaviour of the includes tsconfig option from being inclusive to exclusive. This commit: updates the tsconfig file to fix the issue as well as removes no no longer necessary config options. We updated some type errors that made their way into the codebase during the few days of not type checking the entire codebase Co-Authored-By: devin jameson <devin@thoughtbot.com> Co-authored-by: devin jameson <devin@thoughtbot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Currently our tsconfig is set to only run the ts compiler on files that
end with
.d.tswhich means that the complier is not running on any ofour source files. This was caused by an update to the behaviour of the
includes tsconfig option from being inclusive to exclusive.
This commit:
updates the tsconfig file to fix the issue as well as removes no no
longer necessary config options. We updated some type errors that made
their way into the codebase during the few days of not type checking the
entire codebase
Co-Authored-By: devin jameson devin@thoughtbot.com