Move config out of src #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Currently our build process includes certain files that are expected to be overwritten with files from a remote repo. Some of these files are in our src/ folder which makes git management a pain when testing various builds locally and it is also not intuitive to new contributors during their on boarding how these files are intended to be used. We would like to make this process more clear and easier to maintain. This commit: Moves the configurable files out of ./src/configuration/ and into ./config as to better separate from the source code.
tokumori
pushed a commit
to AlohaSafe/gaen-mobile
that referenced
this pull request
Nov 19, 2020
Why: Currently our build process includes certain files that are expected to be overwritten with files from a remote repo. Some of these files are in our src/ folder which makes git management a pain when testing various builds locally and it is also not intuitive to new contributors during their on boarding how these files are intended to be used. We would like to make this process more clear and easier to maintain. This commit: Moves the configurable files out of ./src/configuration/ and into ./config as to better separate from the source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Currently our build process includes certain files that are expected to
be overwritten with files from a remote repo. Some of these files are in
our src/ folder which makes git management a pain when testing various
builds locally and it is also not intuitive to new contributors during
thier on boarding how these files are intended to be used. We would like
to make this process more clear and easier to maintain.
This commit:
Moves the configurable files out of ./src/configuration/ and into
./config as to better separate from the source code.