Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Translations 11/20 #697

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Update Translations 11/20 #697

merged 2 commits into from
Nov 20, 2020

Conversation

mattThousand
Copy link
Contributor

No description provided.

@@ -6,5 +6,4 @@
<string name="exposure_notification_channel_name">Exposure Notification</string>
<string name="exposure_notification_message">Someone you were near has tested positive for COVID-19. Tap for more info.</string>
<string name="exposure_notification_title">Possible COVID-19 exposure</string>
<string name="background_worker_notification_title">Checking exposures…</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattThousand @juancruzgs this string keeps getting removed during ./src/locales/pull.sh runs, but is referenced in the code:

.setContentTitle(context.getString(R.string.background_worker_notification_title))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @artgibson, will fix

@Ferrumofomega
Copy link
Contributor

LGTM

Copy link
Contributor

@Ferrumofomega Ferrumofomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@Ferrumofomega Ferrumofomega merged commit 30c46da into develop Nov 20, 2020
@Ferrumofomega Ferrumofomega deleted the translations_11_20 branch November 20, 2020 22:10
tokumori pushed a commit to AlohaSafe/gaen-mobile that referenced this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants