Refactor Exposure History screen #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinjameson
force-pushed
the
jts-dj-mb-quaranteen-days
branch
from
e2991f6
to
1589ea1
Compare
tokumori
pushed a commit
to AlohaSafe/gaen-mobile
that referenced
this pull request
Dec 31, 2020
Why: we would like to better inform users about their exposure information. This commit: Introduces two major changes. Firstly, this commit moves the most relevant information from the exposure details screen to the exposure history screen. We decided to do this because the exposure detail screen currently does not provide any additional info on the exposure and always has the same content regarding next steps and health recommendations, regardless of the exposure. For this reason, it makes more sense to include this information on the main exposure history screen if the user has had any exposures within the past 14 days. Secondly, this commit introduces an exposure summary at the top of the exposure history screen, which informs the user how many days remain in their recommended quarantine period if they have a recent exposure. Fixes an issue that caused the Exposure History screen to render more often than necessary, by applying useCallback to the refreshExposureInfo function in the ExposureContext. Co-Authored-By: John Schoeman johnschoeman1617@gmail.com Co-Authored-By: Matt Buckley matt@nicethings.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: we would like to better inform users about their exposure information.
This commit:
Introduces two major changes.
Firstly, this commit moves the most relevant information from the exposure details screen to the exposure history screen. We decided to do this because the exposure detail screen currently does not provide any additional info on the exposure and always has the same content regarding next steps and health recommendations, regardless of the exposure. For this reason, it makes more sense to include this information on the main exposure history screen if the user has had any exposures within the past 14 days.
Secondly, this commit introduces an exposure summary at the top of the exposure history screen, which informs the user how many days remain in their recommended quarantine period if they have a recent exposure.
Fixes an issue that caused the Exposure History screen to render more often than necessary, by applying
useCallbackto therefreshExposureInfofunction in theExposureContext.Co-Authored-By: John Schoeman johnschoeman1617@gmail.com
Co-Authored-By: Matt Buckley matt@nicethings.io