Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated notification when location disabled due to redundant checks #656

Closed
tremblerz opened this issue Apr 24, 2020 · 12 comments
Closed
Assignees

Comments

@tremblerz
Copy link
Contributor

Version

  • Type of phone: Android / iPhone
  • OS Version:
  • Model: iPhone 11 (simulator)

Steps to reproduce

Go to Settings, turn off location

  1. You get notification
  2. now you pull the notification drawer and swipe on notification to get rid of it
  3. Drawer closes and the app comes in foreground and another notification gets triggered
  4. Go to 2.

Expected Behavior

Any event should generate notification only once in general, the way we trigger notification in our app is asynchronously checking states at every screen mount/refresh, we need to shift the logic perhaps

@eyganeshv
Copy link
Contributor

I will check this issue. We need detail clarification on this issue.

@summetj
Copy link
Collaborator

summetj commented Apr 24, 2020

@eyganeshv , post questions you have about this issue here and we will do our best to address them.

@NaziyaNazir
Copy link

This issue is seen for Android also.

@ArchanaNair
Copy link

ArchanaNair commented Apr 30, 2020

@NaziyaNazir, reproducible steps are same for android?

@NaziyaNazir
Copy link

@ArchanaNair Yes, the repro steps are same.

@ArchanaNair
Copy link

May I know the OS version? I am unable to reproduce it on Android, verifying it on OS version 9

@NaziyaNazir
Copy link

@ArchanaNair OS version is Android 9.

@ArchanaNair
Copy link

@NaziyaNazir , I could see the issue when app goes to background and again comes to foreground, but not in the scenario which is given in reproducible step.

@summetj
Copy link
Collaborator

summetj commented Apr 30, 2020

This is starting to sound like a low priority issue, anybody disagree?
And is it strictly a UI/UX issue, or an issue with how the location subsystem works?

@ArchanaNair
Copy link

@NaziyaNazir , I could see the issue when app goes to background and again comes to foreground, but not in the scenario which is given in reproducible step

@tremblerz @NaziyaNazir included a fix for this in android in PR #764

@tstirrat
Copy link
Contributor

I could not get this to reproduce on iOS or Android anymore. I believe it was fixed in #749

@ArchanaNair
Copy link

Yes the issue is fixed in android also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants