Refactor location status checks #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-paths into refactor-location
…-paths into refactor-location
tstirrat
suggested changes
May 4, 2020
app/views/tracking/UnknownPage.js
Outdated
| import MayoInfo from './MayoInfo'; | ||
| import styles from './style'; | ||
|
|
||
| const buttonLabel = languages.t('label.home_enable_location'); |
There was a problem hiding this comment.
Not quite. languages export is a legacy thing. it exports i18next which also has a t but that T wont be fully reactive.
The useTranslation hook will re-render if language is changed. vs languages.t will update if re-rendered by some other means only. Because it's not reactive, it wont trigger a re-render on language change.
tstirrat
previously approved these changes
May 4, 2020
tstirrat
previously approved these changes
May 6, 2020
tstirrat
approved these changes
May 6, 2020
kenpugsley
approved these changes
May 7, 2020
Yeah, that's being tracked here: https://pathcheck.atlassian.net/browse/SAF-85 |
This was referenced May 7, 2020
|
Awesome! |
This was referenced May 10, 2020
aputinski
pushed a commit
to safe-paths-contrib/covid-safe-paths
that referenced
this pull request
May 11, 2020
* official/develop: Fix EULA modal close icon color (Path-Check#792) feat(i18n) Language updates, May 10 (Path-Check#790) feat(GPS) Store Location Data in an encrypted Realm DB (Path-Check#788) Enable location status checks in testing build (Path-Check#787) fix(Onboarding) Fix EULA links to open in device browser (Path-Check#783) chore(Build) Fix debug build error with apache commons-io lib (Path-Check#775, SAF-210) chore(Testing) snapshot tests for LocationTracking, main/* (Path-Check#785) Only render mayo clinic link when language is english (Path-Check#782) fix(UX) Fix pulse alignment on Android devices with “notch” (Path-Check#771) fix(Location) Improve location "tracking" status checks (Path-Check#749) Fix text crop in About screen (Path-Check#774) [iOS] add missing languages (Path-Check#773)
monaabd27
pushed a commit
to monaabd27/covid-safe-paths
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues:
Screenshots:
How to test