Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Kingmaker, fixed Fortify mods to use "Fortified" condition #3928

Merged
merged 3 commits into from Jan 30, 2022

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Jan 20, 2022

Description of the problem being solved:

Kingmaker wasn't using the latest version.
Fortify mods did nothing on legacy items due to calculation changes.
These changes will pair better with #3763

Steps taken to verify a working solution:

  • Vetted Kingmaker on the trade site
  • Made sure minions got the defensive buff
  • Tested several legacy items to ensure they give the fortified condition. Note this doesn't give any fortify stacks until Add support for Willowgift #3763 or changing the config value

Link to a build that showcases this PR:

eNq9W2tT4kgX_jz8ii6q9q2ZGhXCTYfV3UJEh1pxXHFm3v001SQN9JqkmaSjslv-9z2nO8GAIIfsRauckDzn2qfPpcMc__wY-OxeRLFU4UnZOaiWmQhd5clwclL-fHu-f1T--afS8TXX00_j00T6-OSn0ptjc818cS98oCszzaOJ0F8yTvVvwGnGQz0VKhzw31V0obyT8pUKRZmNeOhJnX1yfR7HVzwQJ-WhC8RlxmNXhF73-b4FBlyGQ-XeCX0RqWRmxN5L8TBQHmD6g-tPN7c5oTLMCwWd3xxf-3wuoqHmmsXw56TcAdP5RHyUGlhxPwE-1XLlVewZD-DvdvhwJoT3X8OuI9Ebj4Wr5b3oRlJ3pzx0Ccruih0kvpYzX4pogXcOmpsoPr5g7lQ3sr9Vmvtn18PtiuyKVIRF_ir19NQHX5P4Iro_CaUWZPi1krEKd9KaBO6qYCRDot4ZuHM_oYCV76mHMLfS1Vp9E3rAQ95VMcHVl3IsaMjekIa7gY1JQ6KW1yKCNKPpyu5EkEoYCldBKttFxi4kOTuKCStA2RsWISggaKifs0tt86KL73mg09iIPBOPNH554FFrE7Afahq7PNBpNjerd6-0qX-UtVugWq_VDLeN2H7o0ph-DiMRi-g-V2paRIJ0iSkZHglvxEQQLb0Uwp1eQO2_4VrQtsQC1XzdOYglOQeBa5zTJBLs4BwkXHHOwYfXwDu65yuPCH1ELxTRZD6cSuHTmhO3nSch-TRPQAyHPMmOdvfueZzfXM6Hw9fNsXhadAjoGIDAEyttTvPoHyS5jtTv2Nn5O9J1okAluQR52HjVcAsn2X09ncfShR7FtMQ3wkvcpQR2VNu4GlmTOlD3IoCtYfpbaORzTcbGFuPUhyGA2q0CY9_fiaKjNXfvzpQ3ETsJ2Z1imMxmkCIwzqh05zICR8cyVz_3mwT0JxheunxG6fZwN1IFPKPJAi7lZKpDmCJXpbSoJHRbplzFdDE5OFnEeeLTRpDhnVxGaj7yRZtVH51G66juOZv3vXoAZaY4X8eEPZlDD_hzH7NxN51HIvxjTua_BCcJ6IVeEmF0k2WsUrwUc1wx5w941Q9mKtLmZpf7bmxY9sNZolloDg_iqXoYyNAkphHMMoKH4P0oEan4JSyu0rcwCUY42dp_obtbgwxk7H4bJeMxnj6UQfHIHJn0zs973dv-l15KMhQmJTJX-T6fxcI7KY-5HwOF9NKgGEIpcDUJD4N0evxAQUOpdyMJDqeAcTomqWwOIihIPCcgAWEFuS_oDrudzwRGS0z1WZpcKWgz-5OQdpCnGWiOCGjLIFw-JyEX_Q8J3fNFR_pYaWleG0B42yJNw0PRjOQo0cRoMxMMSQ_s5kkG5jtW4u6gAdP-iaRE2mRSsGldogUltC_kZTsTYwHhTtz2Jp3c8jsRpok1S6LHZq_FLIbseiGC-HQO1esc3bty2LQESDMr88SYJz7e_zXhvtRzTPe5u5f24BjmZob5GTshywY3dwxOv7y0Tzq-TjmgjEx3axkqaE6FO6aXNJ-N-uZoWIaun3gw_KY1emG3z0cou8wmeIzcVUkINSeUPpqSwKAGG1aLoO20TwV3wXNqzAbcC6FR22O3D2r_VoHp7FQp2BtMhFjHvczu2FfYodpnK6qhVqj4m2MwJSW88NWI-7Vn3RYH6vnnzoI98uljpAWjiLsi1avMvlsf9U0KMU5e3DOeX1HTtUaDGKxm2PcvWGa2puFTMar_S_5e0aqAv4xDbHVfUSf3JL05TIIAl67LowjuXkArECw8Xqtuc7klPwUOKeWqbCN23UJMRICfB0Jzj2tewfCKKxjP1rtwZZkva7bj-lkWLOXBXiq5wQMr65xemRRwGwnBuF0RI8NJdx58yL-lQeuquH6xFtE8rRu44iE0RzEOp0f1eplpYJd7Q-S00pc_ltwudc-DUuldIV3F3vl8c2ku3ky1nsXtSuXh4eFgxvVUjcUjTMMHrgoqM2ADWu4bc_dRUKUDP6eTjvkxjCoZp2P7FinOLAdrjOFoLl5cKahj-AxvZh-MM75I8cBiAY3VdKgjtPAPpYLfjPWYrT4Krgd8tghPfJqmunqa6aBxOZPgocgk6WxBEfj_rCU-NgGSOh6vh8IudhILe4D6VfAZRB3eziVEhEKfHEmeBgdm-HQP3cBtPW-zz1f9Xz_3Si9SW2kls7G3tu5V0pr2rmQ_t5lz2EivT3mcnSFLnGWcUgq2oPTDS9Sl4JMErs6ELyOZBKUvVuc226rEdqTpA5htBF7DpyxXCWw3DrAFpVP6M_Vpu_ZEFLugqD9RBS9InKetXkgrYpvVqqU0ltvsYt_8lky83YjvbXZYLUFv7UtX4vN6XsSfMF9NRLt60Hx6__Zo36m9-4FpxfDAgPHQYzjYM9uiYO8c532wjXYxrq9nUN_EwMjczOACqMAZxjzmsJVyxUzWKtWrP2AhigQEncey0yVmppa8_e-dJooM-KMMkoCdQ_Mhx9LlplV6mEKgMm7SGHAZzRnUBEiYSbzYLTlWNRDpmgkDOXqC--xMJZCtmW2udmJXe_pNJWzK7wUzUwM4YY91gYGP7kDnDKew4Pihq8KxnzzuyL4fBEloNIWRAH0D6maTwU6s6k8QwAGMl2wOGv-CrcF2cmsZZ40ln_UeZz4k_D3jPGMn1r4IagkmKD0VMmI4MUDJYeaQJvVsXpkOyE_9LcEvEgoQsyMaxSosCjDI32BcMhOdeO7ezDJoWok2ImpbEdnpiKn9a5L1gtG6ZP0L-CSAFj0qnYl4pjTrPIrnzHYN26520DqoLt-qr7vlOGvuLeG6SQSVSa_Jg8289LUZ6GZ_8ZvLQq1WPgtVc1tnbymXvK1Vq_u1ZvVdfgdnR8xrVnyJtAmkR00aaWOJ1DkE0ipRanOZ9AOQNraQ5vCHNtU9g-1R82p2qu3V9xp7y6Lq1f0VQXi8YgRBIyLvBLOHHBtzvAPOdcC5-ayHw3XpCroZ2BKwf3Avm_25nERNoNqIzHNfovsftCPxjyzGU-2USTexOcuq99K6NXK3kfTDOBlDlpaY0lF55ikRh1a4ZrMIYg6eQD6KmHnBkjo4n7U2yX7frNoitOLW52-6UJg41eVS8p8lllcQja2I5lZEayvi8EWCG8IonB6W2naVYUeq7SyUHanmQOnQnCGc7NDV9r-v9L75Nned1OEDn7HOaB7HuKwmWbHms6BqZtsa0lWyGo3shZ0vDS2o0Dpbtih1Kny9I8k5TGV3rE5SqbZOpXox99KcUPuHyBrFlGwVk9Yq7k1nywKvi6ctK_BRQMundxW0JpJaReRsCT9oz-5FXIRxvfgucorIaxSLBadY5DW2Lw_FsbuyXRdeBQ0n5Z1mAX0K5MD6NjEeFHczeO-4fOu9XCi-mkWISFuSshCF7GwWdmutwLq3iu2kerHwre8eZY3iab9ATDuFnV-nBESDAiqg9t9ofogrWXwVWgWisvgy_I1woaZkpCXuGjq0gOducNSrFUkxtcLuLZgu6OtZxJw6wU9O8WVoFPZWs4g1lP3yYsojB_kWlTpB4q-pbXYqhZHRvOYxb1fM94VUOJaTF1_tEUvvVu0LyXVfHTquZAyOK6v_Qeovfovxpg==```

@Wires77 Wires77 added the enhancement New feature, calculation, or mod label Jan 20, 2022
@LocalIdentity LocalIdentity merged commit fce4146 into PathOfBuildingCommunity:dev Jan 30, 2022
@Wires77 Wires77 deleted the kingmaker_fortify branch February 8, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants