Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete jewels, skills, and equipment by default #3931

Merged
merged 1 commit into from Feb 2, 2022

Conversation

raylu
Copy link
Contributor

@raylu raylu commented Jan 20, 2022

When importing a character, default the 3 delete checkboxes to checked.

Description of the problem being solved:

Just an inconvenience since you generally are not importing characters onto builds with existing content.

Steps taken to verify a working solution:

  • Imported a character twice
  • Checked the skills tab "Sort gems by DPS" was still checked and adding a new support gem offered reasonable options

Before screenshot:

image

After screenshot:

image

When importing a character, default the 3 delete checkboxes to checked.
@pHiney
Copy link
Contributor

pHiney commented Jan 22, 2022

Can the 'Cancel' button be 'Close' instead (just to hijack the PR) ?

@raylu
Copy link
Contributor Author

raylu commented Jan 23, 2022

switched "Cancel" to "Close" in #3939 instead

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jan 25, 2022
@Wires77 Wires77 merged commit 723369a into PathOfBuildingCommunity:dev Feb 2, 2022
@mightyscrub
Copy link

mightyscrub commented Feb 16, 2022

"Just an inconvenience since you generally are not importing characters onto builds with existing content." Thats not true in all cases. I'm doin that all the time (and was really confused until i found this topic - i managed to miss that in the change log).

Maybe you could add an option to the configuration menu so users can pick "their favorite default".

@raylu
Copy link
Contributor Author

raylu commented Feb 16, 2022

could you elaborate on your use case?

@mightyscrub
Copy link

If you are sure it's only "my" use case you shouldn't change anything. I can deal with it. But in my opinion it's not ideal to change defaults, not even to set defaults, without the option that users can override.

@raylu
Copy link
Contributor Author

raylu commented Feb 16, 2022

it would be informative for us, regardless of whether it changes, if you elaborated on your use case. how did you get into a situation where you have items but want to import a character?

@mightyscrub
Copy link

On league start i merge my new character into the old one (if it's "the same" build)

I also import my own characters periodically several times during "progress", keeping gear and jewels. Mostly to keep some kind of history for future uses (above-mentioned). Sometimes only to check which combination will deal more damage. (I know, that it's possible to copy stats form in-game-item and past them into pob. But "my way" feels more convenient.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants