Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display for totem resistances in skill type specific stats #4523

Merged
merged 1 commit into from Jul 11, 2022

Conversation

deathbeam
Copy link
Contributor

@deathbeam deathbeam commented Jul 5, 2022

These stats were parsed but werent displayed anywhere.

Signed-off-by: Tomas Slusny slusnucky@gmail.com

Example screenshot:

image

image

Example pob:

https://pastebin.com/AEuPhhym

These stats were parsed but werent displayed anywhere.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jul 5, 2022
@Lothrik
Copy link
Contributor

Lothrik commented Jul 10, 2022

Tested and works as expected. It's worth noting though that resistances from auras (Purity of Elements, etc) should probably affect totems the same way they currently affect minions.

@deathbeam
Copy link
Contributor Author

I dont think purity of elements affect totems (or auras in general). totems inherit your offensive stats but they arent affected by auras (as this would cause offensive auras to apply to them twice).

@Regisle
Copy link
Member

Regisle commented Jul 10, 2022

iirc totems are affected by all auras, offensive auras do nothing because they use your offensive stats, but defensive auras do help keep them alive

@deathbeam
Copy link
Contributor Author

deathbeam commented Jul 10, 2022

Oh interesting. I know I was looking for this before but also I was specifically searching for purity of elements so did not found much so I assumed its same as with offensive auras. But if i look for defensive auras in general it looks like you are right.

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even without the auras affecting the totems I think this still a useful PR to merge. I'll open a separate bug report for adding that later if someone wants to tackle it.

@Wires77 Wires77 merged commit 9159575 into PathOfBuildingCommunity:dev Jul 11, 2022
@deathbeam deathbeam deleted the totem-res-display branch July 11, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants