[Kalandra] Batch of uniques update. All missingfrom D to L #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Aug 12, 2022
QuickStick123
added a commit
to QuickStick123/PathOfBuilding
that referenced
this pull request
Aug 14, 2022
commit a449985 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:32:53 2022 -0400 Add support for negative levels to gems (PathOfBuildingCommunity#4756) commit fa4aa64 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:25:51 2022 -0400 Fix Thrusting swords were not a base subType (PathOfBuildingCommunity#4720) * Fix: Thrusting should be a base subType * Same changes but with less diff Co-authored-by: Wires77 <Wires77@users.noreply.github.com> commit 9eddc38 Author: Tomas Slusny <slusnucky@gmail.com> Date: Sun Aug 14 05:11:25 2022 +0200 Fix crash when deleting the current skill set (PathOfBuildingCommunity#4772) When removing it from table this causes crash when rebuilding skill set dropdown. Closes PathOfBuildingCommunity#4771 Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Co-authored-by: Tomas Slusny <ts6234@intl.att.com> commit f8298d7 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 04:41:45 2022 +0200 [Kalandra] Update Bitterdream (PathOfBuildingCommunity#4702) * update bitterdream * Remove legacy bitterdream variants commit bc0da55 Author: Paliak <91493239+Paliak@users.noreply.github.com> Date: Sun Aug 14 04:38:17 2022 +0200 FEAT: Add parsing for triple damage mods (PathOfBuildingCommunity#4727) commit 37e8867 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 22:37:51 2022 -0400 [Kalandra] Add support for counting Mastery Type allocations (PathOfBuildingCommunity#4746) * Feat: Add support for counting Mastery Type allocations * added support for on kill portion of ascendancy node * Fix spacing commit f61b17a Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sun Aug 14 12:36:57 2022 +1000 [Kalandra] Update Ngamahu's Sign (PathOfBuildingCommunity#4755) * Update ring.lua Ngamahu's Sign - Perfect (My first one someone check it please!) * remove {variant:1,2,3} not needed commit 14151f8 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 12:34:18 2022 +1000 [Kalandra] Add new uniques (PathOfBuildingCommunity#4774) * add new uniques * Add new Grand Spectrum Jewels Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 2dd0cde Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:15:06 2022 +1000 Update replica bitterdream(PathOfBuildingCommunity#4775) commit 9b9c49f Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:12:56 2022 +1000 Add support for Arrow Dancing (PathOfBuildingCommunity#4779) commit f468faa Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:06:59 2022 +1000 [Kalandra] Update batch 4 of uniques. (PathOfBuildingCommunity#4757) * update uniques * added movement on throwing a trap. Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54d1740 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:57:50 2022 +1000 Update sources of longer obtainable uniques (PathOfBuildingCommunity#4748) * No longer obtainable * Cameria's Avarice now obtainable from vendor recipe. commit 0961142 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:54:36 2022 +1000 update uniques (PathOfBuildingCommunity#4754) commit 3052165 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:49:46 2022 +1000 [Kalandra] Update batch 2 of uniques. (PathOfBuildingCommunity#4751) * set2 update uniques. * Fix bug with wording. * Change to use PercentStat Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit fe51e95 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:43:59 2022 +1000 Update Manastorm and Kongming's Stratagem to new bases (PathOfBuildingCommunity#4783) commit 456c70d Author: LocalIdentity <localidentity2@gmail.com> Date: Sun Aug 14 10:25:33 2022 +1000 Fix Suppression mastery commit 49dd720 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:20:12 2022 +1000 [Kalandra] Update batch 1 of uniques. (PathOfBuildingCommunity#4747) * update * Update ModParser.lua * Update boots.lua * Update ModParser.lua * support * Remove Covered in Ash mod parsing Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54c24b5 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 09:53:41 2022 +1000 Add support for minions have Unholy Might (PathOfBuildingCommunity#4780) commit c65c194 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 01:23:47 2022 +0200 Update brittle values (PathOfBuildingCommunity#4696) commit 6cc2124 Author: Lexy <learn2draw@live.nl> Date: Sat Aug 13 23:14:54 2022 +0200 Update ward recharge speed (PathOfBuildingCommunity#4697) commit dd240b9 Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sat Aug 13 11:58:36 2022 +1000 Update ring.lua (PathOfBuildingCommunity#4773) spelling commit 1fa9ab4 Author: LocalIdentity <localidentity2@gmail.com> Date: Sat Aug 13 11:18:25 2022 +1000 Compact parsing of weapon types for multistrike commit c1903af Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 02:53:33 2022 +0200 Fix: Multistrike damage calculation with skills which have bow and melee Tag (PathOfBuildingCommunity#4740) * wording of blood of karui fixed * undo messy work * damage and atk increase only applies to melee weapons and unarmed * added less attack damage modifier to also apply to bows * adding ModFlag.Attack Condition with bit.bor * Add lines to export files Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 5d94436 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:51:28 2022 +0200 Fix: Blood of the Karui Life recovered and wording (PathOfBuildingCommunity#4729) * wording of blood of karui fixed * Fix: increased life recovered of current version * changed wording for Blood of the karui and Lavianga's Spirit * fixed order and wording * Capitalised Flask Effect Co-authored-by: Sinured <githubmm@use.startmail.com> commit e5ddd8e Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:47:56 2022 +0200 [Kalandra] Batch of uniques update. All missing starting with S (PathOfBuildingCommunity#4753) * all missing uniques starting with S * minions deal no non damage & minions convert phys to xyz * testcommit to check busted * Fix mod parsing format Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 701e719 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:22:08 2022 +0200 Batch of uniques update. All missingfrom D to L (PathOfBuildingCommunity#4769) Co-authored-by: Sinured <githubmm@use.startmail.com> commit f17690d Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:52:07 2022 +0200 [Kalandra] Lifetap & Blessing interaction (PathOfBuildingCommunity#4752) * wording of blood of karui fixed * undo messy work * lifetap cant support skills with blessing tag * testcommit to check busted Co-authored-by: Sinured <githubmm@use.startmail.com> commit d7d91f9 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:49:26 2022 +0200 [Kalandra]Batch of uniques update. All missing starting with R (PathOfBuildingCommunity#4760) * item variants for R added * implements Ralakesh's Impatience unique affix * Add parsing for always Freeze, Shock and Ignite Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 0bfc259 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:28:25 2022 +0200 uniques variants added (PathOfBuildingCommunity#4763) Co-authored-by: Sinured <githubmm@use.startmail.com> commit 4c8127c Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:14:26 2022 +0200 [Kalandra] Batch of unique update. All remaining from M to O (PathOfBuildingCommunity#4767) * adds remaining unique batch from M to O * Fix Ondar's Clasp variant Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit c855506 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 07:31:06 2022 +0930 Add 3.19 Tree (PathOfBuildingCommunity#4744) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * add initial 3_19 tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 78d1390 Author: Nostrademous <nostrademous@hotmail.com> Date: Fri Aug 12 13:47:50 2022 -0400 Fix: when upconverting between trees, if a Mastery lost a mod from its pool that was allocated it would error (PathOfBuildingCommunity#4765) commit c819a68 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 01:24:04 2022 +0930 Update fix_ascendancy_positions.py to support new extra tree nodes (PathOfBuildingCommunity#4357) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 872d4e2 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Fri Aug 12 18:42:10 2022 +0930 Jugg armour applies to ele damage (PathOfBuildingCommunity#4673) * Add support for % of armour applies to elemental damage * add mod parser change * cap percent of armour * fix merge conflict * add breakdown and fix phys not apply * add to main breakdown
QuickStick123
added a commit
to QuickStick123/PathOfBuilding
that referenced
this pull request
Aug 14, 2022
commit a449985 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:32:53 2022 -0400 Add support for negative levels to gems (PathOfBuildingCommunity#4756) commit fa4aa64 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:25:51 2022 -0400 Fix Thrusting swords were not a base subType (PathOfBuildingCommunity#4720) * Fix: Thrusting should be a base subType * Same changes but with less diff Co-authored-by: Wires77 <Wires77@users.noreply.github.com> commit 9eddc38 Author: Tomas Slusny <slusnucky@gmail.com> Date: Sun Aug 14 05:11:25 2022 +0200 Fix crash when deleting the current skill set (PathOfBuildingCommunity#4772) When removing it from table this causes crash when rebuilding skill set dropdown. Closes PathOfBuildingCommunity#4771 Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Co-authored-by: Tomas Slusny <ts6234@intl.att.com> commit f8298d7 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 04:41:45 2022 +0200 [Kalandra] Update Bitterdream (PathOfBuildingCommunity#4702) * update bitterdream * Remove legacy bitterdream variants commit bc0da55 Author: Paliak <91493239+Paliak@users.noreply.github.com> Date: Sun Aug 14 04:38:17 2022 +0200 FEAT: Add parsing for triple damage mods (PathOfBuildingCommunity#4727) commit 37e8867 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 22:37:51 2022 -0400 [Kalandra] Add support for counting Mastery Type allocations (PathOfBuildingCommunity#4746) * Feat: Add support for counting Mastery Type allocations * added support for on kill portion of ascendancy node * Fix spacing commit f61b17a Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sun Aug 14 12:36:57 2022 +1000 [Kalandra] Update Ngamahu's Sign (PathOfBuildingCommunity#4755) * Update ring.lua Ngamahu's Sign - Perfect (My first one someone check it please!) * remove {variant:1,2,3} not needed commit 14151f8 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 12:34:18 2022 +1000 [Kalandra] Add new uniques (PathOfBuildingCommunity#4774) * add new uniques * Add new Grand Spectrum Jewels Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 2dd0cde Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:15:06 2022 +1000 Update replica bitterdream(PathOfBuildingCommunity#4775) commit 9b9c49f Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:12:56 2022 +1000 Add support for Arrow Dancing (PathOfBuildingCommunity#4779) commit f468faa Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:06:59 2022 +1000 [Kalandra] Update batch 4 of uniques. (PathOfBuildingCommunity#4757) * update uniques * added movement on throwing a trap. Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54d1740 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:57:50 2022 +1000 Update sources of longer obtainable uniques (PathOfBuildingCommunity#4748) * No longer obtainable * Cameria's Avarice now obtainable from vendor recipe. commit 0961142 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:54:36 2022 +1000 update uniques (PathOfBuildingCommunity#4754) commit 3052165 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:49:46 2022 +1000 [Kalandra] Update batch 2 of uniques. (PathOfBuildingCommunity#4751) * set2 update uniques. * Fix bug with wording. * Change to use PercentStat Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit fe51e95 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:43:59 2022 +1000 Update Manastorm and Kongming's Stratagem to new bases (PathOfBuildingCommunity#4783) commit 456c70d Author: LocalIdentity <localidentity2@gmail.com> Date: Sun Aug 14 10:25:33 2022 +1000 Fix Suppression mastery commit 49dd720 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:20:12 2022 +1000 [Kalandra] Update batch 1 of uniques. (PathOfBuildingCommunity#4747) * update * Update ModParser.lua * Update boots.lua * Update ModParser.lua * support * Remove Covered in Ash mod parsing Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54c24b5 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 09:53:41 2022 +1000 Add support for minions have Unholy Might (PathOfBuildingCommunity#4780) commit c65c194 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 01:23:47 2022 +0200 Update brittle values (PathOfBuildingCommunity#4696) commit 6cc2124 Author: Lexy <learn2draw@live.nl> Date: Sat Aug 13 23:14:54 2022 +0200 Update ward recharge speed (PathOfBuildingCommunity#4697) commit dd240b9 Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sat Aug 13 11:58:36 2022 +1000 Update ring.lua (PathOfBuildingCommunity#4773) spelling commit 1fa9ab4 Author: LocalIdentity <localidentity2@gmail.com> Date: Sat Aug 13 11:18:25 2022 +1000 Compact parsing of weapon types for multistrike commit c1903af Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 02:53:33 2022 +0200 Fix: Multistrike damage calculation with skills which have bow and melee Tag (PathOfBuildingCommunity#4740) * wording of blood of karui fixed * undo messy work * damage and atk increase only applies to melee weapons and unarmed * added less attack damage modifier to also apply to bows * adding ModFlag.Attack Condition with bit.bor * Add lines to export files Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 5d94436 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:51:28 2022 +0200 Fix: Blood of the Karui Life recovered and wording (PathOfBuildingCommunity#4729) * wording of blood of karui fixed * Fix: increased life recovered of current version * changed wording for Blood of the karui and Lavianga's Spirit * fixed order and wording * Capitalised Flask Effect Co-authored-by: Sinured <githubmm@use.startmail.com> commit e5ddd8e Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:47:56 2022 +0200 [Kalandra] Batch of uniques update. All missing starting with S (PathOfBuildingCommunity#4753) * all missing uniques starting with S * minions deal no non damage & minions convert phys to xyz * testcommit to check busted * Fix mod parsing format Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 701e719 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:22:08 2022 +0200 Batch of uniques update. All missingfrom D to L (PathOfBuildingCommunity#4769) Co-authored-by: Sinured <githubmm@use.startmail.com> commit f17690d Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:52:07 2022 +0200 [Kalandra] Lifetap & Blessing interaction (PathOfBuildingCommunity#4752) * wording of blood of karui fixed * undo messy work * lifetap cant support skills with blessing tag * testcommit to check busted Co-authored-by: Sinured <githubmm@use.startmail.com> commit d7d91f9 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:49:26 2022 +0200 [Kalandra]Batch of uniques update. All missing starting with R (PathOfBuildingCommunity#4760) * item variants for R added * implements Ralakesh's Impatience unique affix * Add parsing for always Freeze, Shock and Ignite Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 0bfc259 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:28:25 2022 +0200 uniques variants added (PathOfBuildingCommunity#4763) Co-authored-by: Sinured <githubmm@use.startmail.com> commit 4c8127c Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:14:26 2022 +0200 [Kalandra] Batch of unique update. All remaining from M to O (PathOfBuildingCommunity#4767) * adds remaining unique batch from M to O * Fix Ondar's Clasp variant Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit c855506 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 07:31:06 2022 +0930 Add 3.19 Tree (PathOfBuildingCommunity#4744) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * add initial 3_19 tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 78d1390 Author: Nostrademous <nostrademous@hotmail.com> Date: Fri Aug 12 13:47:50 2022 -0400 Fix: when upconverting between trees, if a Mastery lost a mod from its pool that was allocated it would error (PathOfBuildingCommunity#4765) commit c819a68 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 01:24:04 2022 +0930 Update fix_ascendancy_positions.py to support new extra tree nodes (PathOfBuildingCommunity#4357) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 872d4e2 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Fri Aug 12 18:42:10 2022 +0930 Jugg armour applies to ele damage (PathOfBuildingCommunity#4673) * Add support for % of armour applies to elemental damage * add mod parser change * cap percent of armour * fix merge conflict * add breakdown and fix phys not apply * add to main breakdown
Wires77
pushed a commit
that referenced
this pull request
Apr 1, 2023
…ge (#4541) * Fix all sources of arcane surge passing also improve passing of other buffs. * Address most requested changes. * clean up some white spaces. * fix non-damaging ailment effect and add types to data. * fix merge mistakes * Switch channelling to time * Squashed commit of the following: commit a449985 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:32:53 2022 -0400 Add support for negative levels to gems (#4756) commit fa4aa64 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:25:51 2022 -0400 Fix Thrusting swords were not a base subType (#4720) * Fix: Thrusting should be a base subType * Same changes but with less diff Co-authored-by: Wires77 <Wires77@users.noreply.github.com> commit 9eddc38 Author: Tomas Slusny <slusnucky@gmail.com> Date: Sun Aug 14 05:11:25 2022 +0200 Fix crash when deleting the current skill set (#4772) When removing it from table this causes crash when rebuilding skill set dropdown. Closes #4771 Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Co-authored-by: Tomas Slusny <ts6234@intl.att.com> commit f8298d7 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 04:41:45 2022 +0200 [Kalandra] Update Bitterdream (#4702) * update bitterdream * Remove legacy bitterdream variants commit bc0da55 Author: Paliak <91493239+Paliak@users.noreply.github.com> Date: Sun Aug 14 04:38:17 2022 +0200 FEAT: Add parsing for triple damage mods (#4727) commit 37e8867 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 22:37:51 2022 -0400 [Kalandra] Add support for counting Mastery Type allocations (#4746) * Feat: Add support for counting Mastery Type allocations * added support for on kill portion of ascendancy node * Fix spacing commit f61b17a Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sun Aug 14 12:36:57 2022 +1000 [Kalandra] Update Ngamahu's Sign (#4755) * Update ring.lua Ngamahu's Sign - Perfect (My first one someone check it please!) * remove {variant:1,2,3} not needed commit 14151f8 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 12:34:18 2022 +1000 [Kalandra] Add new uniques (#4774) * add new uniques * Add new Grand Spectrum Jewels Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 2dd0cde Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:15:06 2022 +1000 Update replica bitterdream(#4775) commit 9b9c49f Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:12:56 2022 +1000 Add support for Arrow Dancing (#4779) commit f468faa Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:06:59 2022 +1000 [Kalandra] Update batch 4 of uniques. (#4757) * update uniques * added movement on throwing a trap. Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54d1740 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:57:50 2022 +1000 Update sources of longer obtainable uniques (#4748) * No longer obtainable * Cameria's Avarice now obtainable from vendor recipe. commit 0961142 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:54:36 2022 +1000 update uniques (#4754) commit 3052165 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:49:46 2022 +1000 [Kalandra] Update batch 2 of uniques. (#4751) * set2 update uniques. * Fix bug with wording. * Change to use PercentStat Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit fe51e95 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:43:59 2022 +1000 Update Manastorm and Kongming's Stratagem to new bases (#4783) commit 456c70d Author: LocalIdentity <localidentity2@gmail.com> Date: Sun Aug 14 10:25:33 2022 +1000 Fix Suppression mastery commit 49dd720 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:20:12 2022 +1000 [Kalandra] Update batch 1 of uniques. (#4747) * update * Update ModParser.lua * Update boots.lua * Update ModParser.lua * support * Remove Covered in Ash mod parsing Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54c24b5 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 09:53:41 2022 +1000 Add support for minions have Unholy Might (#4780) commit c65c194 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 01:23:47 2022 +0200 Update brittle values (#4696) commit 6cc2124 Author: Lexy <learn2draw@live.nl> Date: Sat Aug 13 23:14:54 2022 +0200 Update ward recharge speed (#4697) commit dd240b9 Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sat Aug 13 11:58:36 2022 +1000 Update ring.lua (#4773) spelling commit 1fa9ab4 Author: LocalIdentity <localidentity2@gmail.com> Date: Sat Aug 13 11:18:25 2022 +1000 Compact parsing of weapon types for multistrike commit c1903af Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 02:53:33 2022 +0200 Fix: Multistrike damage calculation with skills which have bow and melee Tag (#4740) * wording of blood of karui fixed * undo messy work * damage and atk increase only applies to melee weapons and unarmed * added less attack damage modifier to also apply to bows * adding ModFlag.Attack Condition with bit.bor * Add lines to export files Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 5d94436 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:51:28 2022 +0200 Fix: Blood of the Karui Life recovered and wording (#4729) * wording of blood of karui fixed * Fix: increased life recovered of current version * changed wording for Blood of the karui and Lavianga's Spirit * fixed order and wording * Capitalised Flask Effect Co-authored-by: Sinured <githubmm@use.startmail.com> commit e5ddd8e Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:47:56 2022 +0200 [Kalandra] Batch of uniques update. All missing starting with S (#4753) * all missing uniques starting with S * minions deal no non damage & minions convert phys to xyz * testcommit to check busted * Fix mod parsing format Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 701e719 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:22:08 2022 +0200 Batch of uniques update. All missingfrom D to L (#4769) Co-authored-by: Sinured <githubmm@use.startmail.com> commit f17690d Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:52:07 2022 +0200 [Kalandra] Lifetap & Blessing interaction (#4752) * wording of blood of karui fixed * undo messy work * lifetap cant support skills with blessing tag * testcommit to check busted Co-authored-by: Sinured <githubmm@use.startmail.com> commit d7d91f9 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:49:26 2022 +0200 [Kalandra]Batch of uniques update. All missing starting with R (#4760) * item variants for R added * implements Ralakesh's Impatience unique affix * Add parsing for always Freeze, Shock and Ignite Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 0bfc259 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:28:25 2022 +0200 uniques variants added (#4763) Co-authored-by: Sinured <githubmm@use.startmail.com> commit 4c8127c Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:14:26 2022 +0200 [Kalandra] Batch of unique update. All remaining from M to O (#4767) * adds remaining unique batch from M to O * Fix Ondar's Clasp variant Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit c855506 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 07:31:06 2022 +0930 Add 3.19 Tree (#4744) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * add initial 3_19 tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 78d1390 Author: Nostrademous <nostrademous@hotmail.com> Date: Fri Aug 12 13:47:50 2022 -0400 Fix: when upconverting between trees, if a Mastery lost a mod from its pool that was allocated it would error (#4765) commit c819a68 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 01:24:04 2022 +0930 Update fix_ascendancy_positions.py to support new extra tree nodes (#4357) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 872d4e2 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Fri Aug 12 18:42:10 2022 +0930 Jugg armour applies to ele damage (#4673) * Add support for % of armour applies to elemental damage * add mod parser change * cap percent of armour * fix merge conflict * add breakdown and fix phys not apply * add to main breakdown * Revert "Squashed commit of the following:" This reverts commit 1d7c641. * Revert "Revert "Squashed commit of the following:"" This reverts commit b0ebcd7. * fix merge issues. * fix typo * Fix redundant stuff on hits with spells * Fix missing bracket * Update arcane surge
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…ge (PathOfBuildingCommunity#4541) * Fix all sources of arcane surge passing also improve passing of other buffs. * Address most requested changes. * clean up some white spaces. * fix non-damaging ailment effect and add types to data. * fix merge mistakes * Switch channelling to time * Squashed commit of the following: commit a449985 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:32:53 2022 -0400 Add support for negative levels to gems (PathOfBuildingCommunity#4756) commit fa4aa64 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 23:25:51 2022 -0400 Fix Thrusting swords were not a base subType (PathOfBuildingCommunity#4720) * Fix: Thrusting should be a base subType * Same changes but with less diff Co-authored-by: Wires77 <Wires77@users.noreply.github.com> commit 9eddc38 Author: Tomas Slusny <slusnucky@gmail.com> Date: Sun Aug 14 05:11:25 2022 +0200 Fix crash when deleting the current skill set (PathOfBuildingCommunity#4772) When removing it from table this causes crash when rebuilding skill set dropdown. Closes PathOfBuildingCommunity#4771 Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Signed-off-by: Tomas Slusny <ts6234@intl.att.com> Co-authored-by: Tomas Slusny <ts6234@intl.att.com> commit f8298d7 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 04:41:45 2022 +0200 [Kalandra] Update Bitterdream (PathOfBuildingCommunity#4702) * update bitterdream * Remove legacy bitterdream variants commit bc0da55 Author: Paliak <91493239+Paliak@users.noreply.github.com> Date: Sun Aug 14 04:38:17 2022 +0200 FEAT: Add parsing for triple damage mods (PathOfBuildingCommunity#4727) commit 37e8867 Author: Nostrademous <nostrademous@hotmail.com> Date: Sat Aug 13 22:37:51 2022 -0400 [Kalandra] Add support for counting Mastery Type allocations (PathOfBuildingCommunity#4746) * Feat: Add support for counting Mastery Type allocations * added support for on kill portion of ascendancy node * Fix spacing commit f61b17a Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sun Aug 14 12:36:57 2022 +1000 [Kalandra] Update Ngamahu's Sign (PathOfBuildingCommunity#4755) * Update ring.lua Ngamahu's Sign - Perfect (My first one someone check it please!) * remove {variant:1,2,3} not needed commit 14151f8 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 12:34:18 2022 +1000 [Kalandra] Add new uniques (PathOfBuildingCommunity#4774) * add new uniques * Add new Grand Spectrum Jewels Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 2dd0cde Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:15:06 2022 +1000 Update replica bitterdream(PathOfBuildingCommunity#4775) commit 9b9c49f Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:12:56 2022 +1000 Add support for Arrow Dancing (PathOfBuildingCommunity#4779) commit f468faa Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 11:06:59 2022 +1000 [Kalandra] Update batch 4 of uniques. (PathOfBuildingCommunity#4757) * update uniques * added movement on throwing a trap. Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54d1740 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:57:50 2022 +1000 Update sources of longer obtainable uniques (PathOfBuildingCommunity#4748) * No longer obtainable * Cameria's Avarice now obtainable from vendor recipe. commit 0961142 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:54:36 2022 +1000 update uniques (PathOfBuildingCommunity#4754) commit 3052165 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:49:46 2022 +1000 [Kalandra] Update batch 2 of uniques. (PathOfBuildingCommunity#4751) * set2 update uniques. * Fix bug with wording. * Change to use PercentStat Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit fe51e95 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:43:59 2022 +1000 Update Manastorm and Kongming's Stratagem to new bases (PathOfBuildingCommunity#4783) commit 456c70d Author: LocalIdentity <localidentity2@gmail.com> Date: Sun Aug 14 10:25:33 2022 +1000 Fix Suppression mastery commit 49dd720 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 10:20:12 2022 +1000 [Kalandra] Update batch 1 of uniques. (PathOfBuildingCommunity#4747) * update * Update ModParser.lua * Update boots.lua * Update ModParser.lua * support * Remove Covered in Ash mod parsing Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 54c24b5 Author: QuickStick <31533893+QuickStick123@users.noreply.github.com> Date: Sun Aug 14 09:53:41 2022 +1000 Add support for minions have Unholy Might (PathOfBuildingCommunity#4780) commit c65c194 Author: Lexy <learn2draw@live.nl> Date: Sun Aug 14 01:23:47 2022 +0200 Update brittle values (PathOfBuildingCommunity#4696) commit 6cc2124 Author: Lexy <learn2draw@live.nl> Date: Sat Aug 13 23:14:54 2022 +0200 Update ward recharge speed (PathOfBuildingCommunity#4697) commit dd240b9 Author: Nightblade <Nightblade@users.noreply.github.com> Date: Sat Aug 13 11:58:36 2022 +1000 Update ring.lua (PathOfBuildingCommunity#4773) spelling commit 1fa9ab4 Author: LocalIdentity <localidentity2@gmail.com> Date: Sat Aug 13 11:18:25 2022 +1000 Compact parsing of weapon types for multistrike commit c1903af Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 02:53:33 2022 +0200 Fix: Multistrike damage calculation with skills which have bow and melee Tag (PathOfBuildingCommunity#4740) * wording of blood of karui fixed * undo messy work * damage and atk increase only applies to melee weapons and unarmed * added less attack damage modifier to also apply to bows * adding ModFlag.Attack Condition with bit.bor * Add lines to export files Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 5d94436 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:51:28 2022 +0200 Fix: Blood of the Karui Life recovered and wording (PathOfBuildingCommunity#4729) * wording of blood of karui fixed * Fix: increased life recovered of current version * changed wording for Blood of the karui and Lavianga's Spirit * fixed order and wording * Capitalised Flask Effect Co-authored-by: Sinured <githubmm@use.startmail.com> commit e5ddd8e Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:47:56 2022 +0200 [Kalandra] Batch of uniques update. All missing starting with S (PathOfBuildingCommunity#4753) * all missing uniques starting with S * minions deal no non damage & minions convert phys to xyz * testcommit to check busted * Fix mod parsing format Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 701e719 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 01:22:08 2022 +0200 Batch of uniques update. All missingfrom D to L (PathOfBuildingCommunity#4769) Co-authored-by: Sinured <githubmm@use.startmail.com> commit f17690d Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:52:07 2022 +0200 [Kalandra] Lifetap & Blessing interaction (PathOfBuildingCommunity#4752) * wording of blood of karui fixed * undo messy work * lifetap cant support skills with blessing tag * testcommit to check busted Co-authored-by: Sinured <githubmm@use.startmail.com> commit d7d91f9 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:49:26 2022 +0200 [Kalandra]Batch of uniques update. All missing starting with R (PathOfBuildingCommunity#4760) * item variants for R added * implements Ralakesh's Impatience unique affix * Add parsing for always Freeze, Shock and Ignite Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 0bfc259 Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:28:25 2022 +0200 uniques variants added (PathOfBuildingCommunity#4763) Co-authored-by: Sinured <githubmm@use.startmail.com> commit 4c8127c Author: Sinured <100538010+Sinured@users.noreply.github.com> Date: Sat Aug 13 00:14:26 2022 +0200 [Kalandra] Batch of unique update. All remaining from M to O (PathOfBuildingCommunity#4767) * adds remaining unique batch from M to O * Fix Ondar's Clasp variant Co-authored-by: Sinured <githubmm@use.startmail.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit c855506 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 07:31:06 2022 +0930 Add 3.19 Tree (PathOfBuildingCommunity#4744) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * add initial 3_19 tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 78d1390 Author: Nostrademous <nostrademous@hotmail.com> Date: Fri Aug 12 13:47:50 2022 -0400 Fix: when upconverting between trees, if a Mastery lost a mod from its pool that was allocated it would error (PathOfBuildingCommunity#4765) commit c819a68 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Sat Aug 13 01:24:04 2022 +0930 Update fix_ascendancy_positions.py to support new extra tree nodes (PathOfBuildingCommunity#4357) * add Initial support for adding non-Tree nodes to Tree (Nine lives) * update positions and add other dummy nodes * separate stats and reminder text and add new nodes * rest of nodes * Fix comma * fix spelling of sapped * update spec.lua for passiveSkills * remove unrelated spec * update file to hardcode group and node IDs, and correct ascendency * update to new tree * spelling fix Co-authored-by: LocalIdentity <localidentity2@gmail.com> commit 872d4e2 Author: Regisle <49933620+Regisle@users.noreply.github.com> Date: Fri Aug 12 18:42:10 2022 +0930 Jugg armour applies to ele damage (PathOfBuildingCommunity#4673) * Add support for % of armour applies to elemental damage * add mod parser change * cap percent of armour * fix merge conflict * add breakdown and fix phys not apply * add to main breakdown * Revert "Squashed commit of the following:" This reverts commit 1d7c641. * Revert "Revert "Squashed commit of the following:"" This reverts commit b0ebcd7. * fix merge issues. * fix typo * Fix redundant stuff on hits with spells * Fix missing bracket * Update arcane surge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doedre's Tenure: perfect
Doomfletch: perfect
Dusktoe: perfect
Emperor's Vigilance: perfect
Foxshade: perfect. implemented "increased Movement Speed while on Full Life"
Giantsbane: implemented arrow pierce 2 additional targets; unsure affix order
Gruthkul's Pelt: perfect
The Highwayman: perfect
Hrimsorrow: perfect
Hyrri's Truth: unsure about affix order; bow attacks have culling strike implemented
Icetomb: perfect. I assume we won't support chance to Freeze Enemies for 1 second when Hit
The Ignomon: unsure about affix order
Infernal Mantle: perfect
Kaom's Sign: unsure about affix order
Kikazaru: perfect
Kintsugi: perect
Lightning Coil: perfect
Lochtonial Caress: perfect