Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for crafting Crucible Mods on items #6071

Merged
merged 2 commits into from Apr 20, 2023
Merged

Conversation

LocalIdentity
Copy link
Contributor

@LocalIdentity LocalIdentity commented Apr 17, 2023

Adds initial support for Crucible mods
Things to do

  • Use it's own button with 6 dropdowns, 1 for each tier
  • Restrict button to make it only appear on weapons
  • Add support for the unique helmet
  • Add support for the unique staff
  • Fix sort order for mods
  • Potentially use the sliding scale as we do for prefix/suffix mods so we don't need to display each tier of a mod in the list

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Apr 17, 2023
@Nightblade
Copy link
Contributor

(pob-dict: ./src/Data/Crucible.lua added to the list of auto-generated files in cspell.json)

* add new button for crucible mods, separate by node
show button only for weapons and shields

* add button to remove crucible mods

* refactor node dropdowns

* Fix Notable export

* Fix projectile speed stat

* "Remove" button UI refactor
"Allocate" mods - substitute id for name

* checkLine update

* dynamic buttons for normal,unique rarity
remove crucibleControl as it is not needed

* populate dropdown with active crucible mods

* unique staff, sword, helmet

* unique helmet update

* Add blank parsing for crucible uniques

* canHaveMod refactor, Quick is smart

* refactor custom tagging

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
@LocalIdentity LocalIdentity merged commit 669d9fa into dev Apr 20, 2023
2 checks passed
@LocalIdentity LocalIdentity deleted the add_crucible-mods branch April 20, 2023 13:44
@LocalIdentity LocalIdentity changed the title Initial Support for Crucible Mods on items Support for crafting Crucible Mods on items Apr 20, 2023
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
)

* Initial Support for Crucible Mods on items

* Support for Crucible Mods (PathOfBuildingCommunity#6076)

* add new button for crucible mods, separate by node
show button only for weapons and shields

* add button to remove crucible mods

* refactor node dropdowns

* Fix Notable export

* Fix projectile speed stat

* "Remove" button UI refactor
"Allocate" mods - substitute id for name

* checkLine update

* dynamic buttons for normal,unique rarity
remove crucibleControl as it is not needed

* populate dropdown with active crucible mods

* unique staff, sword, helmet

* unique helmet update

* Add blank parsing for crucible uniques

* canHaveMod refactor, Quick is smart

* refactor custom tagging

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants