Fix Crash on clicking "Show All Configurations" in new build #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Dec 31, 2023
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7129
Description of the problem being solved:
Fixes a crash caused by comparing a number to nil. I'm not exactly sure why the code is written the way it is but when the
maxColvariable is bigger than 1 andcoldefaults to 1 failing this:PathOfBuilding/src/Classes/ConfigTab.lua
Line 726 in 46c98d3
check the first element of the colY table is never actually set. This pr defaults the first element to 0 following the logic in the loop:
PathOfBuilding/src/Classes/ConfigTab.lua
Line 731 in 46c98d3