Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allocated nodes on Cluster Jewels when importing character #7221

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 9, 2024

Fixes #6718

Description of the problem being solved:

On character import, when Delete Jewels is true, we are keeping the state of cluster jewels in a subgraph. This functionality is used elsewhere in the case where you remove a cluster from the tree and then add it back in. We keep the allocated nodes so that it automatically loads back in when the cluster is returned. The problem is when importing, we're keeping the state of the nodes, including any additionally allocated ones, "in case the cluster comes back" and of course it does because it's part of the import data. So we see the cluster again and allocate all the nodes that were there at time of Import, including ones the Import possibly does not have.

So this PR adds a flag that is set true during Import Delete Jewel true that will ignore saving the state of the cluster jewels for that flow. The flag is reset after deallocating all nodes from the jewels.

Steps taken to verify a working solution:

  • Import a character with a cluster jewel, e.g. account name dyfrgi, league Ancestor, character ShockingWaffle.
  • Set an extra passive in the large cluster, e.g. the extra small passive in the upper left for Foe Bliss.
  • Import the passive tree again with Delete Jewels: true. Observe that the extra passive is NOT allocated.

Link to a build that showcases this PR:

Account name dyfrgi, league All, character ShockingWaffle.
In this case, the Delete Jewels: true is the problem, so character import is required.

Before screenshot:

clusterSubgraph2

After screenshot:

clusterSubgraph

@Peechey Peechey added the bug Something isn't working label Jan 9, 2024
@LocalIdentity LocalIdentity merged commit c4dd477 into PathOfBuildingCommunity:dev Jan 11, 2024
2 checks passed
@Peechey Peechey deleted the fix/cluster_jewel_subgraph_on_import branch January 12, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing passive trees with cluster jewels always reallocates unallocated passive after it has been set once
2 participants