Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inspiration Charges not applying to Minion Skills #7243

Merged
merged 2 commits into from Jan 13, 2024

Conversation

sida-wang
Copy link
Contributor

Fixes #7235 .

Description of the problem being solved:

Currently PoB has a condition that only applies inspiration charges if the main skill is not a minion skill.
I believe this is to stop inspiration charges from affecting minions however this also removes the buff from the player portion of minion skills.
This PR changes the condition to only apply when the actor is the player.

Steps taken to verify a working solution:

  • Tested with a few minion skills to confirm inspiration charges doesn't affect minion portion but affects the player portion.

Before screenshot:

Refer linked issue

After screenshot:

image

@sida-wang
Copy link
Contributor Author

Noting that this will conflict with #7186

@sida-wang sida-wang added the bug:behaviour Behavioral differences label Jan 13, 2024
@LocalIdentity LocalIdentity merged commit 56a4d66 into PathOfBuildingCommunity:dev Jan 13, 2024
2 checks passed
@sida-wang sida-wang deleted the issue-7235 branch January 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspiration doesn't work with Absolution of Inspiring and Dominating Blow of Inspiring
2 participants