Fix Minion stats values #7253
Merged
Fix Minion stats values #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
force-pushed
the
fix_minion-damage
branch
from
070662b
to
b99ab18
Compare
ifnjeff
reviewed
Jan 17, 2024
LocalIdentity
force-pushed
the
fix_minion-damage
branch
from
4aa7fac
to
1b4c8f6
Compare
added 2 commits
January 19, 2024 23:54
We were using the incorrect column in DefaultMonsterStats The damage difference is ~20% less at level 70 vs the default monster damage table. I'm not sure if this should apply to Spectre skills so will need to confirm with GGG Damage now lines up with the SRS damage from this spreadsheet https://docs.google.com/spreadsheets/d/1mhh3rQ54_CsRPC37PLqlr_XPIlhy26HP7PjFHSJbUco/edit?usp=sharing
Adds support for minons to use the alternate life tables Fixes the handling of the DamageFixup stat Add support for handling the baseDamageIgnoresAttackSpeed on some minions
LocalIdentity
force-pushed
the
fix_minion-damage
branch
from
1b4c8f6
to
2774b02
Compare
added 4 commits
January 20, 2024 06:37
Evasion and Armour values were quite wrong with the previous formula Could technically change the evasion formula to be 100% correct but I believe it's better just just use the look up table and be 99.5% correct and be a bit more performant Not 100% sure on the Accuracy table though and need to check with Openarl
|
Damage fixup implemented in #7268 |
* Fix Base minion Attack damage values We were using the incorrect column in DefaultMonsterStats The damage difference is ~20% less at level 70 vs the default monster damage table. I'm not sure if this should apply to Spectre skills so will need to confirm with GGG Damage now lines up with the SRS damage from this spreadsheet https://docs.google.com/spreadsheets/d/1mhh3rQ54_CsRPC37PLqlr_XPIlhy26HP7PjFHSJbUco/edit?usp=sharing * Support new life tables / fixup multi / base damage flag Adds support for minons to use the alternate life tables Fixes the handling of the DamageFixup stat Add support for handling the baseDamageIgnoresAttackSpeed on some minions * fix: implement damage fixup as skill mods --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
LocalIdentity
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the incorrect column in DefaultMonsterStats
The damage difference is ~20% less at level 70 vs the default monster damage table.
I'm not sure if this should apply to Spectre skills so will need to confirm with GGG
edit: applies to all monsters with the IsPlayerMinion tag in MonsterTypes.dat
Damage now lines up with the SRS damage from this spreadsheet https://docs.google.com/spreadsheets/d/1mhh3rQ54_CsRPC37PLqlr_XPIlhy26HP7PjFHSJbUco/edit?usp=sharing
edit 1:
Fixes the handling of the damageFixup stat on minions
Adds support for minons to use the alternate life tables
Add support for handling the baseDamageIgnoresAttackSpeed on some minions
edit2:
Fixes the calculation of Minion armour and evasion base values+
Fix minion accuracy calculations
Use game constants for the damage effectiveness calcs