Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Law of the Wilds using the wrong minion stats #7254

Merged
merged 1 commit into from Jan 17, 2024

Conversation

LocalIdentity
Copy link
Contributor

Fixes #6967

Description of the problem being solved:

Law of the Wilds was using the wrong base minion for its stats so the damage was very far off.

It was also using the wrong actor level for the minion and I believe it always grabs the level from the levelRequirement stat and the base_display_minion_actor_level is only used for the tooltip in game but not the actual minion itself.
The only other minion with differing base_display_minion_actor_level vs levelrequirement is Vaal Summon Skeletons. I'll will check this assumption with GGG

Steps taken to verify a working solution:

  • Test build to make sure the minion stats changed and it uses the new actor level

Link to a build that showcases this PR:

https://pobb.in/6GoR-wJPrqTJ

Before screenshot:

image

After screenshot:

image

Law of the Wilds was using the wrong base minion for its stats so the damage was very far off.

It was also using the wrong actor level for the minion and I believe it always grabs the level from the `levelRequirement` stat and the `base_display_minion_actor_level` is only used for the tooltip in game but not the actual minion itself.
The only other minion with differing `base_display_minion_actor_level ` vs `levelrequirement` is Vaal Summon Skeletons. I'll will check this assumption with GGG
@LocalIdentity LocalIdentity added the bug:calculation Numerical differences label Jan 16, 2024
@LocalIdentity LocalIdentity merged commit 53c0ee5 into dev Jan 17, 2024
2 checks passed
@LocalIdentity LocalIdentity deleted the fix_law-of-the-wilds branch January 17, 2024 17:18
@JDomenici-nWay
Copy link

Thank you for looking into this! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectral Wolf Companion stats are inaccurate for Law of the Wilds
2 participants