Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip for maximum charges granted from overriding sources #7328

Merged
merged 1 commit into from Feb 1, 2024

Conversation

sida-wang
Copy link
Contributor

Fixes #7326 .

Description of the problem being solved:

Currently there is no mod in the modDB to display for overridden maximum charges from Badge of the Brotherhood and the Masterful Form Slayer Ascendancy.

This PR implements a step in doActorCharges to add an OVERRIDE mod to the modDB which gets picked up in the tooltip.

I'm not sure this is the best way of doing things as adding to the modDB during the calcs seems like bad practice. Happy to discuss and implement changes as suggested by others.

Also given how many times doActorCharges is called, this implementation uses a modDB:HasMod() call to check if the mod already exists. It seems like modDB:HasModInternal has a very unique implementation of source matching:

(not source or mod.source:match("[^:]+") == source)

As such, I've ensured that the sources in the modDB:HasMod() call follow the same treatment but it appears the matches would occur for any source that matches Item or Tree for the sources Badge of the Brotherhood and Masterful Form respectively.

Steps taken to verify a working solution:

  • Tested with Badge of the Brotherhood and the Masterful Form Slayer Ascendancy to see if power charges are reflected correctly in the Calcs tab.

After screenshot:

image
image

@sida-wang sida-wang added the bug:accuracy Wording differences label Jan 29, 2024
@LocalIdentity LocalIdentity merged commit 46337c4 into PathOfBuildingCommunity:dev Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge of the Brotherhood not being shown as frenzy charge source
2 participants