Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Nightgrip missing "taken" keyword in description #7383

Merged
merged 1 commit into from Mar 22, 2024

Conversation

Ciccooz
Copy link
Contributor

@Ciccooz Ciccooz commented Mar 11, 2024

Fixes #7379

Description of the problem being solved:

Nightgrip was missing the "taken" keyword and this led to an incorrect calculation of Effective Hit Pool

Steps taken to verify a working solution:

Imported the build below and compared the equipped Nightgrip with the one selected from the uniques tab, now the Effective Hit Pool is not messed up

Link to a build that showcases this PR:

https://pobb.in/gVGiXS9lqxya

Before screenshot:

7379_before

After screenshot:

7379_after

@Paliak Paliak added the bug:accuracy Wording differences label Mar 11, 2024
@LocalIdentity LocalIdentity merged commit c89d36a into PathOfBuildingCommunity:dev Mar 22, 2024
2 checks passed
@Ciccooz Ciccooz deleted the 7379 branch March 24, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightgrip Gloves from the Unique Tab have the wrong text and cause wrong eHP values
3 participants