Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Simple Graphic v2.0 #7399

Merged
merged 2 commits into from Mar 22, 2024
Merged

Update to Simple Graphic v2.0 #7399

merged 2 commits into from Mar 22, 2024

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Mar 22, 2024

This updates the graphics backend to not rely on raw OpenGL anymore. Ideally, nothing about the program behavior will change, and PoB will potentially get faster when rendering. See the commit history in https://github.com/PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic for more detail of all the work @zao has put in.

There is one known issue in #6764, but this upgrade should hopefully solve a myriad of other graphical and crashing issues we've seen over the years. I'll list them all here so they can get auto-closed. Most of these issues are difficult/impossible for our team to reproduce, so assuming they're fixed and waiting for new issues to come in is the best we can do. Thanks to @QuickStick123 for compiling all of these issues!

Graphical Issues

Fixes #2007, #2314, #2784, #3595, #4109, #4360, #4363, #2996, #4503, #4958

Crashes

Fixes #2502, #2570, #3722, #4340, #4384, #1843, #3794, #4180, #2701, #3618, #2465, #4736

Unsure if this would fix #2181 or #3497 (doubtful on that one)

@Wires77 Wires77 added the enhancement New feature, calculation, or mod label Mar 22, 2024
@LocalIdentity LocalIdentity merged commit 01c9881 into dev Mar 22, 2024
1 of 2 checks passed
@LocalIdentity LocalIdentity deleted the simple_graphic_2 branch March 22, 2024 16:29
@Wires77 Wires77 mentioned this pull request Mar 22, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
2 participants