Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ngamahu, Flame's Advance working correctly with Timeless jewels #7611

Conversation

NL908
Copy link
Contributor

@NL908 NL908 commented May 3, 2024

… Jewels

Fixes #7610.
Fixes #7604.

Description of the problem being solved:

Steps taken to verify a working solution:

Link to a build that showcases this PR:

https://pobb.in/1TKnO-VH2o8g

Before screenshot:

PassiveBefore
FlamedashBefore

After screenshot:

PassiveAfter
FlamedashAfter

@Paliak Paliak added the bug:calculation Numerical differences label May 21, 2024
@LocalIdentity LocalIdentity changed the title Fixed ModParser for "Ngamahu, Flame's Advance" not excluding Timeless… Fix Ngamahu, Flame's Advance working correctly with Timeless jewels Jun 27, 2024
@LocalIdentity LocalIdentity merged commit 52e1f4a into PathOfBuildingCommunity:dev Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:calculation Numerical differences
Projects
None yet
3 participants