Make sure script runs through a terminal #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pathoschild
force-pushed
the
develop
branch
2 times, most recently
from
e201c96
to
3793d2e
Compare
Pathoschild
approved these changes
Jul 7, 2024
Pathoschild
added
the
enhancement
|
Merged into |
Pathoschild
added a commit
that referenced
this pull request
Jul 7, 2024
Make sure script runs through a terminal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some terminal emulator checking and detection to 'install on Linux.sh' to fix issue #929. Only checks a few terminals, but should be enough to get by. Alerts user via
notify-sendif none of the checked terminals are found, instructing them to launch the script through a terminal