Doubt

[theapache64]

First of all, awesome repository. Got a lot to learn in it. 😃

I've a doubt in your code.

Here,

Foodium/app/src/main/java/dev/shreyaspatil/foodium/data/repository/NetworkBoundRepository.kt

Lines 93 to 94 in 75e4541

	@MainThread
	protected abstract suspend fun fetchFromRemote(): Response<REQUEST>

,

Why did you marked fetchFromRemote with @MainThread ? Should it be called from WorkerThread? 🤔

[PatilShreyas]

These annotations don't do much. They're like the comment to indicate which thread the function should be called from. This function is already suspend. We're running flow on IO thread. That's why it doesn't matters too much here.

[theapache64]

Yeah, but why it's not @workerthread ? as It's a network request, it should be marked as @workerthread right ?

…

On Fri, Apr 17, 2020, 1:41 PM Shreyas Patil ***@***.***> wrote: These annotations don't do much. They're like the comment to indicate which thread the function should be called from. This function is already suspend. We're running flow on IO thread. That's why it doesn't matters too much here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJ23RZWUJRHFAEVMJLRILTRNAFL3ANCNFSM4MKLYQ6Q> .

[PatilShreyas]

It's not intentional. Just annotated it with @mainthread as convention (so many repos with same functionality were annotated it with @mainthread)

[DanteAndroid]

@PatilShreyas Hi, obviously suspend fun should not be annotated with @MainThread. Never heard of this kind of convention.

[PatilShreyas]

Hi, @DanteAndroid basically these annotations don't do much, they're like a comment to indicate which thread the function should be called from. This prevents the error of calling a function from other thread. Here, it means this function should be called from the main thread.