Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note delete confirmation #287

Closed
yogeshpaliyal opened this issue Oct 27, 2021 · 6 comments · Fixed by #298 or #327
Closed

Note delete confirmation #287

yogeshpaliyal opened this issue Oct 27, 2021 · 6 comments · Fixed by #298 or #327
Labels
noty-android
Projects
NotyKT
Milestone
v1.3.1

Comments

@yogeshpaliyal
Copy link
Contributor

It will be great to having an confirmation before deleting the note.
@PatilShreyas
Copy link
Owner

Thanks, @yogeshpaliyal for reporting this. That's good idea.

@PatilShreyas PatilShreyas added this to To do in NotyKT via automation Oct 29, 2021
@PatilShreyas PatilShreyas added this to the v1.3.1 milestone Oct 29, 2021
@kasem-sm
Copy link
Contributor

Can I create a PR for this?

@kasem-sm kasem-sm mentioned this issue Oct 30, 2021
Closed
@kasem-sm
Copy link
Contributor

There are three possible ways:

  1. Show a confirmation Dialog with Yes and No and then dele.
  2. Show a snack bar (for a short duration) that the note is deleted and Undo it.
  3. After showing confirmation dialog and if the user clicks yes, then show a snack bar to undo the deletion (again for a short duration) and after that delete permanently.

Which one would be preferred?

@PatilShreyas
Copy link
Owner

Sure @kasem-sm. First one sounds good - simple to use.

@PatilShreyas PatilShreyas mentioned this issue Oct 31, 2021
Merged
5 tasks
@PatilShreyas
Copy link
Owner

@kasem-sm I've already raised PR for this. You can review it and add your suggestions if you have any: #298

@kasem-sm
Copy link
Contributor

Looks great! Nice.

@PatilShreyas PatilShreyas linked a pull request Nov 1, 2021 that will close this issue
[ComposeApp] Show confirmation dialogs in the app #298
Merged
5 tasks
@PatilShreyas PatilShreyas moved this from To do to In progress in NotyKT Nov 10, 2021
@PatilShreyas PatilShreyas mentioned this issue Nov 16, 2021
Merged
5 tasks
@PatilShreyas PatilShreyas linked a pull request Nov 16, 2021 that will close this issue
Release NotyKT v1.3.1 #327
Merged
5 tasks
NotyKT automation moved this from In progress to Done Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
noty-android
Projects
NotyKT
Status: Done
NotyKT
Done
Milestone
v1.3.1
3 participants
@yogeshpaliyal @PatilShreyas @kasem-sm