Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release NotyKT v1.3.1 #327

Merged
merged 44 commits into from Nov 16, 2021
Merged

Release NotyKT v1.3.1 #327

merged 44 commits into from Nov 16, 2021

Conversation

PatilShreyas
Copy link
Owner

@PatilShreyas PatilShreyas commented Nov 16, 2021 •
edited

Summary

Release v1.3.1 (2021-11-16)

This release includes a few improvements and fixes in the Jetpack Compose Application to make it better.

🐛 Bug Fixes

  • [#281] Earlier, After signup, navigating back takes to log in screen. Now it closes the app.
  • [#282] Show proper cards with proper shadow in About screen. (Contributed by @yogeshpaliyal)
  • [#284] Removed focus (cursor) from fields while sharing image of a note. (Contributed by @yogeshpaliyal)
  • [#286] Improved dark mode visibility. (Contributed by @yogeshpaliyal)
  • [#294] Earlier, flickering (recompositions) were happening after performing navigation through screens.

✅ Improvements

  • [#280] Provided helper message for input fields like username and password for better UX in Login/Signup screens.
  • [#283] Improved touch region area of note input fields. (Contributed by @yogeshpaliyal)
  • [#287] Show confirmation dialog before deleting a note.
  • [#297] Show confirmation dialog before logging out.

🎯 Codebase Improvements

  • Used decorationBox property of Composable TextField to show/hide placeholder instead of manually handling in a box.
  • Removed jcenter() from Gradle repositories (Contributed by @sairajsawant)

Many Thanks to superstar ⭐ contributors @yogeshpaliyal, @sairajsawant for contributing PRs and @kasem-sm for raising issues

Checklist

  • Build and linting is passing.
  • This change is not breaking existing flow of a system.
  • I have written test case for this change.
  • This change is tested from all aspects.
  • Implemented any new third-party library (Which not existed before this change).

dependabot bot and others added 30 commits October 28, 2021 02:03
@dependabot
[Android]: Bump lifecycleVersion from 2.3.1 to 2.4.0 in /noty-android
a179a90 
Bumps `lifecycleVersion` from 2.3.1 to 2.4.0.

Updates `lifecycle-viewmodel-ktx` from 2.3.1 to 2.4.0

Updates `lifecycle-livedata-ktx` from 2.3.1 to 2.4.0

Updates `lifecycle-runtime-ktx` from 2.3.1 to 2.4.0

---
updated-dependencies:
- dependency-name: androidx.lifecycle:lifecycle-viewmodel-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.lifecycle:lifecycle-livedata-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.lifecycle:lifecycle-runtime-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@yogeshpaliyal
Fix surface color on Login and Signup
efdbf65
@yogeshpaliyal
Fix About card shadow cut
4837d36
@yogeshpaliyal
Code formatting
11cffa4
@yogeshpaliyal
Remove focus from fields on share as Image
46b9a3e
@yogeshpaliyal
Increase touch region area for Input fields
7a301af
@PatilShreyas
Merge pull request #295 from yogeshpaliyal/improve/dark_mode
9c35e1a 
[ComposeApp] Improve UI for dark mode
@yogeshpaliyal
Send Medifier for BasicTextField in BasicNotyTextField
0ee9f1b
@PatilShreyas
Merge pull request #296 from yogeshpaliyal/fix/share
8ed29b3 
[ComposeApp] Improve touch region area of input fields, Remove focus from fields on sharing image
@PatilShreyas
Use decorationBox instead of manually handling text field
bae72db
@PatilShreyas
Create common composable component for confirmation dialog
9a184d4
@PatilShreyas
Show logout confirmation dialog on login screen
d3dd682
@PatilShreyas
Show delete confirmation on note detail screen before deleting a note
70e0fe0
@PatilShreyas
Use LaunchedEffect for handling navigation to Login
491cf40
@PatilShreyas
Use LaunchedEffect for handling navigation to Notes screen via Login …
ae1ba27 
…and Signup screens
@PatilShreyas
Merge pull request #298 from PatilShreyas/feature/confirmation-dialogs
09d06fd 
[ComposeApp] Show confirmation dialogs in the app
@PatilShreyas
Merge pull request #300 from PatilShreyas/fix/navigation-issues
6c2241b 
[ComposeApp] Fix navigation issues
@sairajphonepe
--remove: jcenter
a58d78e
@sairajphonepe
Merge branch 'v1.3.1-dev' of https://github.com/sairajsawant/NotyKT i…
37dbf8d 
…nto remove-jcenter
@PatilShreyas
Merge pull request #310 from sairajsawant/remove-jcenter
9cf010f 
Remove jcenter
@PatilShreyas
Merge pull request #288 from PatilShreyas/dependabot/gradle/noty-andr…
8f6be29 
…oid/lifecycleVersion-2.4.0

[Android]: Bump lifecycleVersion from 2.3.1 to 2.4.0 in /noty-android
@dependabot
[Android]: Bump lifecycleVersion from 2.3.1 to 2.4.0 in /noty-android
a5f33e0 
Bumps `lifecycleVersion` from 2.3.1 to 2.4.0.

Updates `lifecycle-viewmodel-ktx` from 2.3.1 to 2.4.0

Updates `lifecycle-livedata-ktx` from 2.3.1 to 2.4.0

Updates `lifecycle-runtime-ktx` from 2.3.1 to 2.4.0

---
updated-dependencies:
- dependency-name: androidx.lifecycle:lifecycle-viewmodel-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.lifecycle:lifecycle-livedata-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.lifecycle:lifecycle-runtime-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@PatilShreyas
Merge pull request #312 from PatilShreyas/dependabot/gradle/noty-andr…
54fe66e 
…oid/lifecycleVersion-2.4.0

[Android]: Bump lifecycleVersion from 2.3.1 to 2.4.0 in /noty-android
@dependabot
[Android]: Bump daggerHiltVersion from 2.40 to 2.40.1 in /noty-android
8d7c4ff 
Bumps `daggerHiltVersion` from 2.40 to 2.40.1.

Updates `hilt-android-gradle-plugin` from 2.40 to 2.40.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.40...dagger-2.40.1)

Updates `hilt-android` from 2.40 to 2.40.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.40...dagger-2.40.1)

Updates `hilt-android-compiler` from 2.40 to 2.40.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.40...dagger-2.40.1)

---
updated-dependencies:
- dependency-name: com.google.dagger:hilt-android-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.google.dagger:hilt-android
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.google.dagger:hilt-android-compiler
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
[Android]: Bump lifecycleVersion from 2.3.1 to 2.4.0 in /noty-android
f7e3b72 
Bumps `lifecycleVersion` from 2.3.1 to 2.4.0.

Updates `lifecycle-viewmodel-ktx` from 2.3.1 to 2.4.0

Updates `lifecycle-livedata-ktx` from 2.3.1 to 2.4.0

Updates `lifecycle-runtime-ktx` from 2.3.1 to 2.4.0

---
updated-dependencies:
- dependency-name: androidx.lifecycle:lifecycle-viewmodel-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.lifecycle:lifecycle-livedata-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.lifecycle:lifecycle-runtime-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@PatilShreyas
Merge pull request #314 from PatilShreyas/dependabot/gradle/noty-andr…
738f1b3 
…oid/daggerHiltVersion-2.40.1

[Android]: Bump daggerHiltVersion from 2.40 to 2.40.1 in /noty-android
@PatilShreyas
Merge branch 'master' of github.com:PatilShreyas/NotyKT into fix/fiel…
296e9ac 
…d-helpertext
@dependabot
[Android]: Bump daggerHiltVersion from 2.40 to 2.40.1 in /noty-android
2fda433 
Bumps `daggerHiltVersion` from 2.40 to 2.40.1.

Updates `hilt-android-gradle-plugin` from 2.40 to 2.40.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.40...dagger-2.40.1)

Updates `hilt-android` from 2.40 to 2.40.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.40...dagger-2.40.1)

Updates `hilt-android-compiler` from 2.40 to 2.40.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.40...dagger-2.40.1)

---
updated-dependencies:
- dependency-name: com.google.dagger:hilt-android-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.google.dagger:hilt-android
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.google.dagger:hilt-android-compiler
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
[Android]: Bump lottie-compose from 4.2.0 to 4.2.1 in /noty-android
7826f55 
Bumps [lottie-compose](https://github.com/airbnb/lottie-android) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/airbnb/lottie-android/releases)
- [Changelog](https://github.com/airbnb/lottie-android/blob/master/CHANGELOG.md)
- [Commits](airbnb/lottie-android@v4.2.0...v4.2.1)

---
updated-dependencies:
- dependency-name: com.airbnb.android:lottie-compose
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
[Android]: Bump lottie from 4.2.0 to 4.2.1 in /noty-android
a08d8fd 
Bumps [lottie](https://github.com/airbnb/lottie-android) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/airbnb/lottie-android/releases)
- [Changelog](https://github.com/airbnb/lottie-android/blob/master/CHANGELOG.md)
- [Commits](airbnb/lottie-android@v4.2.0...v4.2.1)

---
updated-dependencies:
- dependency-name: com.airbnb.android:lottie
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@PatilShreyas
Merge pull request #321 from PatilShreyas/dependabot/gradle/noty-andr…
9a822d3 
…oid/com.airbnb.android-lottie-4.2.1

[Android]: Bump lottie from 4.2.0 to 4.2.1 in /noty-android
@PatilShreyas
Merge pull request #320 from PatilShreyas/dependabot/gradle/noty-andr…
9c90a61 
…oid/com.airbnb.android-lottie-compose-4.2.1

[Android]: Bump lottie-compose from 4.2.0 to 4.2.1 in /noty-android
@PatilShreyas
Merge pull request #318 from PatilShreyas/dependabot/gradle/noty-andr…
95797e5 
…oid/daggerHiltVersion-2.40.1

[Android]: Bump daggerHiltVersion from 2.40 to 2.40.1 in /noty-android
@PatilShreyas
Merge pull request #316 from PatilShreyas/dependabot/gradle/noty-andr…
9c44693 
…oid/lifecycleVersion-2.4.0

[Android]: Bump lifecycleVersion from 2.3.1 to 2.4.0 in /noty-android
@PatilShreyas
Provide prop "helperText" to common text field
de9d944
@PatilShreyas
Provide helperText for username and password fields
f9b1b7e
@PatilShreyas
Fix icon image bounds on Login screen
e616ba5
@PatilShreyas
Remove unnecessary property setting to surface
4cb7a3c
@PatilShreyas
Fix: overriding ViewModelProvider.Factory implementation
6704d4e
@PatilShreyas
Merge branch 'v1.3.1-dev' of github.com:PatilShreyas/NotyKT into fix/…
664838a 
…field-helpertext
@PatilShreyas
Merge branch 'master' of github.com:PatilShreyas/NotyKT into fix/fiel…
6b3b9a4 
…d-helpertext
@PatilShreyas
Merge pull request #326 from PatilShreyas/fix/field-helpertext
2610656 
Provide helper messages for Username and Password fields
@PatilShreyas
Update changelog.md
d028b3e
@PatilShreyas PatilShreyas changed the title V1.3.1 dev Release NotyKT v1.3.1 Nov 16, 2021
This was linked to issues Nov 16, 2021
Add Alert/Helper text for Password Validation #280
Closed
[Navigation Issues] After signup, navigating back takes to Login screen #281
Closed
About page - Shadow cutting of visit card #282
Closed
Add Note - Increase Fields default touch region #283
Closed
Showing cursor in Shared Note as Image #284
Closed
Save exported notes to Media Dir instead of Cache Dir #285
Closed
Dark mode Improvements #286
Closed
Note delete confirmation #287
Closed
[Navigation issues] Recompositions on logout #294
Closed
Sign out Confirmation #297
Closed
@PatilShreyas PatilShreyas removed a link to an issue Nov 16, 2021
Save exported notes to Media Dir instead of Cache Dir #285
Closed
@PatilShreyas PatilShreyas merged commit b85a447 into master Nov 16, 2021
@PatilShreyas PatilShreyas deleted the v1.3.1-dev branch November 16, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
noty-android release🚀
Projects
None yet
Milestone
No milestone
3 participants
@PatilShreyas @yogeshpaliyal @sairajphonepe