Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign out Confirmation #297

Closed
kasem-sm opened this issue Oct 30, 2021 · 3 comments · Fixed by #298 or #327
Closed

Sign out Confirmation #297

kasem-sm opened this issue Oct 30, 2021 · 3 comments · Fixed by #298 or #327
Labels
noty-android
Projects
NotyKT
Milestone
v1.3.1

Comments

@kasem-sm
Copy link
Contributor

As issue #287 suggests for a confirmation alert for deleting notes, I think that confirmation before signing out a user is also necessary.
@PatilShreyas
Copy link
Owner

@kasem-sm yeah, that's nice to have 😃

@PatilShreyas PatilShreyas added this to To do in NotyKT via automation Oct 30, 2021
@PatilShreyas PatilShreyas added this to the v1.3.1 milestone Oct 30, 2021
@PatilShreyas PatilShreyas mentioned this issue Oct 31, 2021
Merged
5 tasks
@PatilShreyas PatilShreyas linked a pull request Nov 1, 2021 that will close this issue
[ComposeApp] Show confirmation dialogs in the app #298
Merged
5 tasks
@PatilShreyas PatilShreyas moved this from To do to In progress in NotyKT Nov 10, 2021
@kasem-sm
Copy link
Contributor Author

Is there anything remaining in here so I may help?

@PatilShreyas
Copy link
Owner

@kasem-sm this is done. Will close ticket once fix is merged in master and released.

@PatilShreyas PatilShreyas mentioned this issue Nov 16, 2021
Merged
5 tasks
@PatilShreyas PatilShreyas linked a pull request Nov 16, 2021 that will close this issue
Release NotyKT v1.3.1 #327
Merged
5 tasks
NotyKT automation moved this from In progress to Done Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
noty-android
Projects
NotyKT
Status: Done
NotyKT
Done
Milestone
v1.3.1
2 participants
@PatilShreyas @kasem-sm