Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 536 loading of progress indefinitely when no notes available #544

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Fix issue 536 loading of progress indefinitely when no notes available #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1315d0
[API]: Bump logback-classic from 1.4.1 to 1.4.3 in /noty-api
dependabot[bot] Oct 3, 2022
e7ef7a5
[API]: Bump testContainerVersion from 1.17.4 to 1.17.5 in /noty-api
dependabot[bot] Oct 5, 2022
9767d45
Merge pull request #540 from PatilShreyas/dependabot/gradle/noty-api/…
PatilShreyas Oct 5, 2022
3ebfd72
Merge pull request #537 from PatilShreyas/dependabot/gradle/noty-api/…
PatilShreyas Oct 5, 2022
44cc639
Fix issue 536 loading of progress indefinitely when no notes available
Varsha-Kulkarni Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...d/app/simpleapp/src/main/java/dev/shreyaspatil/noty/simpleapp/view/notes/NotesFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,7 @@ class NotesFragment : BaseFragment<NotesFragmentBinding, NotesState, NotesViewMo

private fun isConnected(): Boolean? = viewModel.currentState.isConnectivityAvailable

private fun shouldSyncNotes() = viewModel.currentState
.let { state -> state.error != null || state.notes.isEmpty() }
private fun shouldSyncNotes() = viewModel.currentState.error != null

override fun getViewBinding(
inflater: LayoutInflater,
Expand Down
4 changes: 2 additions & 2 deletions noty-api/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ buildscript {
ktorVersion = "1.6.8"
exposedVersion = "0.39.2"
postgresVersion = "42.3.1"
logbackVersion = "1.4.1"
logbackVersion = "1.4.3"
daggerVersion = "2.44"
testContainerVersion = "1.17.4"
testContainerVersion = "1.17.5"
kotestVersion = "5.5.0"
}

Expand Down