Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put preview-window on bottom in _fzf_search_processes #227

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Put preview-window on bottom in _fzf_search_processes #227

merged 1 commit into from
Feb 25, 2022

Conversation

jaminthorns
Copy link
Contributor

ps outputs in a tabular format, and since the _fzf_search_processes function runs ps for a single process to generate the preview, the content of the preview is much more "horizontal" (similar to the _fzf_search_history function) since it's a single row of information.

This PR specifies that the preview-window for _fzf_search_processes should be on the bottom, 4 pixels tall, and wrapped. Since the header will always take up the first line, this gives the COMMAND 3 lines to wrap (same amount of lines that _fzf_search_history gives commands to wrap).

Before

Screen Shot 2022-02-24 at 9 50 25 AM

After

Screen Shot 2022-02-24 at 9 50 38 AM

@PatrickF1
Copy link
Owner

Wow that's a really great idea. We already do similar for search command history so why not for this one as well, where we might end up with very long lines! Thank you @jaminthorns !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants