-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add write back support for unmount option and copy to support for mount option #4
Conversation
Also add copy to ramdisk option for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! @psdzzm
First of all sorry for the delay in my response to your PR. I think it's a great addition to this project. I have noted a couple of small fixes about logging. When you fix them I will proceed to run the workflow and merge this into the main branch.
Also, could you add a test case for copy_to and copy_back?
Thanks a lot for your contribution and interest in this project! 😄
Hey! No problem. Almost there, please run Thanks! |
Everything good! Thanks a lot for your interest and contribution to |
Available in crates.io as from |
If possible, you can add the copy to and back option in README. Both mount and remount use |
Yep. Just updated the README and also the workflow as the tests were failing sometimes due to test parallelism. |
Add a
-c, --copy-back
option for the unmount operation.Achieved by using
cp
instead ofstd::fs::copy
, because cargo uses the file timestamps to determine if a file has changed.