migrate to hardhat-chai-matchers and hardhat-toolbox

[ahmedali8]

Resolves issue: #112

[ahmedali8]

Resolves issue: #120

[PaulRBerg]

Hi @ahmedali8, thanks for your PR. Happy to merge this, but it looks like there are conflicts now. Could you please take a look at resolve them?

This must have happened after I merged #116.

[ahmedali8]

Hey @PaulRBerg. Conflicts resolved!

[PaulRBerg]

Hey @ahmedali8, just submitted my review. Here's a bit of additional feedback, if I may:

1. It looks like you merged my main branch instead of rebasing - in the majority of cases like this when you submit a PR to a repo and that repo has updated its main tip, it's better to use git rebase instead. Rebasing keeps the historical commits in chronological order and it also tends to create fewer git conflicts.
2. It looks like you didn't give me permission to contribute to your branch - this is generally useful so that I don't have to request changes from your for every minor thing that should be changed that I could change myself.
3. It's clearer for historical purposes to create a bespoke branch name on your fork, e.g. in this case something like refactor/hardhat-toolbox would have been nice.

[ahmedali8]

hey @PaulRBerg, thanks alot for the guidance.

1. I'll make sure to follow this for future PRs as I didn't know this previously.
2. given you permission already since the beginning, screenshot attached.
3. should I close this and create a new PR or what should I do please guide?

[PaulRBerg]

given you permission already since the beginning, screenshot attached.

Oh, shoot. Sorry then! My bad.