Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent to load scripts before compilation and typechain #60

Closed
wants to merge 2 commits into from

Conversation

hadv
Copy link

@hadv hadv commented Aug 19, 2021

to fix #59

@PaulRBerg
Copy link
Owner

Thanks! I will hold off merging this for now, because selectively loading tasks based on environment vars might lead to unexpected results with Hardhat. Or at least that's what I understood talking to them on Discord.

Cc @fvictorio, @alcuadrado, would @hadv's solution break Hardhat somehow?

@hadv
Copy link
Author

hadv commented Aug 20, 2021

Sorry, I will close PR and keep the source code on my repo only due to I add some other commits that not related to the issue

@hadv hadv closed this Aug 20, 2021
@alcuadrado
Copy link

Thanks! I will hold off merging this for now, because selectively loading tasks based on environment vars might lead to unexpected results with Hardhat. Or at least that's what I understood talking to them on Discord.

Cc @fvictorio, @alcuadrado, would @hadv's solution break Hardhat somehow?

It would only mess up hh, but not hardhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An unexpected error occurred when run yarn compile
3 participants