Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bootstrap pnpm monorepo with mock packages #128

Closed
wants to merge 10 commits into from
Closed

chore: bootstrap pnpm monorepo with mock packages #128

wants to merge 10 commits into from

Conversation

scorpion9979
Copy link

@scorpion9979 scorpion9979 commented Jun 28, 2023 •
edited
Loading

Addresses #112
Forked from 2fc7d99

PaulRBerg and others added 5 commits June 24, 2023 12:09
@PaulRBerg
fix: check for plugin method collisions
6c92d17 
test: adjust tests in light of new contract logic
test: improve writing in state trees
@PaulRBerg
fix: use owner as CREATE2 salt
0636044 
docs: improve writing in README
refactor: delete "nextSeeds"
refactor: delete stale CREATE2 seeds
refactor: remove "origin" in "DeployProxy" event
test: remove unused constants
test: update tests in light of new contract logic
test: remove stale "origin" fuzzing
@PaulRBerg
refactor: redesign plugins
2897e45 
docs: polish NatSpe comments
feat: add getters for retrieving plugin methods
feat: store plugin methods in reverse mapping
refactor: rename "methodList" to "methods"
refactor: update error names
test: rename "dummy" to "basic"
test: update tests for "installPlugin" and "uninstallPlugin"
@PaulRBerg
feat: add "deployAndInstallPlugin"
2fc7d99 
docs: polish NatSpec comments
@scorpion9979
chore: bootstrap pnpm monorepo with mock packages
ccd2ef7
@scorpion9979 scorpion9979 changed the base branch from main to refactor/plugin-redesign June 28, 2023 00:28
@scorpion9979 scorpion9979 changed the base branch from refactor/plugin-redesign to main June 28, 2023 00:29
@scorpion9979
Copy link
Author

@PaulRBerg are we looking to add a release workflow?

@PaulRBerg PaulRBerg changed the base branch from main to refactor/plugin-redesign June 28, 2023 06:56
@PaulRBerg
Copy link
Owner

Thanks, @scorpion9979. Could you also work on the following tasks?

  • Move the root repo into packages/proxy (except for the README, which I will take care of myself)
  • Re-use the config files.prettierrc.yml, .prettierignore and .solhint.json by keeping them at the root and referencing them via scripts in each package.json
  • Add the repository field in each package.json

are we looking to add a release workflow?

No, not yet.

@scorpion9979
chore(proxy): move all package files to packages/proxy
0b6810a
@scorpion9979
chore(sdk,subgraph,targets): add the repository field in each package…
fdfc41b 
….json

chore(sdk,subgraph,targets): re-order fields in each package.json
build(sdk,subgraph,targets): add "prettier" as dev dependency
@scorpion9979
chore(proxy,sdk,subgraph,targets): fix path to prettier config in pac…
89c2c29 
…kage.json

chore(proxy): fix path to solhint config in package.json
@scorpion9979
chore(proxy): move forge-std and prb-test dev dependencies to package…
93d9f5f 
…s/proxy

chore(proxy): move .gitmodules back to root directory
@scorpion9979
ci: set working-directory for proxy jobs
e408a26
@PaulRBerg PaulRBerg deleted the branch PaulRBerg:refactor/plugin-redesign June 29, 2023 13:41
@PaulRBerg PaulRBerg closed this Jun 29, 2023
@scorpion9979
Copy link
Author

scorpion9979 commented Jun 29, 2023 •
edited
Loading

@PaulRBerg I've added the changes discussed above. Note the file changes in .gitmodules to maintain compatibility with how forge install seems to work, inspired by Optimisim's PNPM-Foundry monorepo. I've also taken liberty in setting the working-directory field in the GitHub actions to specify the current working directory to be packages/proxy, although I haven't yet tested it. I also just added one extra commit to address the fatal: pathspec '.gitmodules' did not match any files error when running forge install <dep_name> from inside packages/proxy without having a local .gitmodules in there, but the changes have not been reflected in this PR as it was closed.

@PaulRBerg
Copy link
Owner

Thank you for the update, @scorpion9979!

I accidentally closed the PR when I deleted the refactor/plugin-redesign branch - could you re-open it against main, please?

@PaulRBerg PaulRBerg mentioned this pull request Jul 3, 2023
Closed
@scorpion9979 scorpion9979 mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scorpion9979 @PaulRBerg