Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bootstrap pnpm monorepo with mock packages #140

Closed
wants to merge 10 commits into from
Closed

chore: bootstrap pnpm monorepo with mock packages #140

wants to merge 10 commits into from

Conversation

scorpion9979
Copy link

Addresses #112
Re-opened from PR #128, as the original PR was automatically closed when refactor/plugin-redesign was deleted.

@scorpion9979 scorpion9979 force-pushed the refactor/monorepo branch 2 times, most recently from f8b7b1d to 3d46c56 Compare July 3, 2023 23:24
@scorpion9979
chore: bootstrap pnpm monorepo with mock packages
9c2f7e6
@scorpion9979
chore(proxy): move all package files to packages/proxy
e27a9a2
@scorpion9979
chore(sdk,subgraph,targets): add the repository field in each package…
eecb519 
….json

chore(sdk,subgraph,targets): re-order fields in each package.json
build(sdk,subgraph,targets): add "prettier" as dev dependency
@scorpion9979
chore(proxy,sdk,subgraph,targets): fix path to prettier config in pac…
ee48997 
…kage.json

chore(proxy): fix path to solhint config in package.json
@scorpion9979
chore(proxy): move forge-std and prb-test dev dependencies to package…
b78a9fd 
…s/proxy

chore(proxy): move .gitmodules back to root directory
@scorpion9979 scorpion9979 force-pushed the refactor/monorepo branch 2 times, most recently from 4c714d9 to 5ace302 Compare July 4, 2023 01:37
@scorpion9979
chore(proxy): fix forge fatal pathspec error
b731163
@scorpion9979
chore: move deployAndExecuteAndInstallPlugin.t.sol to the relevant pa…
4f63853 
…th in packages/proxy

chore: move deployAndExecuteAndInstallPlugin.tree to the relevant path in packages/proxy
chore: add .gitignore to root directory
chore(proxy): move pnpm lockfile back to root directory
build: update pnpm lockfile
@scorpion9979
ci: set working-directory for proxy jobs
8b88576
@scorpion9979
Copy link
Author

scorpion9979 commented Jul 4, 2023 •
edited
Loading

Hey @PaulRBerg. Picking up our conversation from PR #128..

I believe the changes are ready to be reviewed . Also, here's my suggestion for next steps to be taken:

  • Modify root package.json to use Lerna or nx to run package scripts in parallel (e.g., root package.json in Optimism's monorepo).
  • Update the repo name, description, version, ..etc in root package.json.
  • Verify that working-directory is behaving as expected for proxy CI jobs.

@PaulRBerg
Copy link
Owner

Thanks for putting together the PR and for the tips, Ahmed.

Why do we need Lerna or nx when pnpm run supports workspaces out of the box?

@scorpion9979
Copy link
Author

scorpion9979 commented Jul 4, 2023 •
edited
Loading

Why do we need Lerna or Nx when pnpm run supports workspaces out of the box?

Good point! I did not realize pnpm run supports workspaces, but Optimism still seems to use Nx even though their monorepo has migrated to use pnpm. Nx seems to have official support for pnpm, and comes with advanced features configured via an nx.json file. Using Nx could be an overkill in our case—at least at this point in time.

@PaulRBerg PaulRBerg force-pushed the main branch 3 times, most recently from f175e70 to 972afc9 Compare July 10, 2023 14:09
@PaulRBerg
Copy link
Owner

Thanks again for your PR, @scorpion9979.

I will close this PR because:

  1. We have decided to remove PRBProxy in Sablier V2.1 (see the changelog).
  2. There are no other active users.

As ar result, I am not going to maintain this project anymore.

@PaulRBerg PaulRBerg closed this Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scorpion9979 @PaulRBerg