Fixes memory corruption from pointer to array on stack #2
Conversation
ghost
mentioned this pull request
|
@PaulStoffregen Could this get merged? It's already been tested on a Teensy 3.1, and it fixes the mentioned bug |
|
Ping |
|
Wow, this old library was a huge mess! I've just made several more small fixes. I tested all the examples, but deleted the scroll_multi example which no longer works with the smaller buffer. Can you please take a look? Maybe try with your hardware? |
|
Thanks, I'll try to test it this week |
|
These recent changes broke the ability to connect multiple displays. Since it's documented on the Arduino Playground page, even with an image, I'm going to try restoring that functionality. |
|
Hopefully it's all working well. I feel pretty good about it, since I tested all the examples here with a couple different boards (both ARM & AVR). I'm going to assume "no news is good news" on more issues.... |
|
Yeah I honestly haven't had time to run it on any hardware yet, but I looked at the changes and everything seemed good. If I notice any other issues I'll make another PR. |
This bug was seriously screwing with things, it allocates an array on the stack, saves a pointer to it, and continues to modify the location in memory after the function where the array was allocated has returned.