Relations can now be a method or a property

[gmajoulet]

You have now 2 ways to declare a relation :

{
    relations: []
}

or

{
    relations: function () {
        return [];
    }
}

(I also removed trailing spaces)

[PaulUithol]

What would you use this for?

[gmajoulet]

It becomes easier to override if you use an interface.
That's how they're doing it in Backbone, it lets the developper override property the same way if they're either from Backbone or from Backbone relational

Example for the "events" Backbone property : https://github.com/jashkenas/backbone/blob/master/backbone.js#L1064

[gmajoulet]

Any update on this small improvement?

[PaulUithol]

I would merge it right away if you could provide a patch without all the other changes (removing whitespace), since that will cause merge conflicts on (most) other pull requests. I'd rather do that some other time myself.

[gmajoulet]

Ok, I'll do that asap. Thanks

Le 24 juil. 2013 à 14:57, Paul Uithol notifications@github.com a écrit :

I would merge it right away if you could provide a patch without all the other changes (removing whitespace), since that will cause merge conflicts on (most) other pull requests. I'd rather do that some other time myself.

—
Reply to this email directly or view it on GitHub.

[gmajoulet]

Done!

Thanks

[PaulUithol]

Sorry, had to take this out.. this breaks with submodels. We directly modify the relations array in a couple of places, which is not possible when it's defined as a function. The only way around this would be to directly execute (and store) the function's results whenever we first encounter a model.. but that may be defeating the purpose of having a function in the first place.