Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #375 - toJSON should include IDs of unregistered models #376

Merged
merged 4 commits into from Oct 29, 2013

Conversation

@philfreo
Copy link
Collaborator

philfreo commented Jul 10, 2013

Possible fix for #375

Side effect (seems fine to me) is that it also continues to return IDs of deleted models, which
seems less magic and more expected to me - also allows for 'soft deletes' where an object itself
is deleted but other objects can still have references to it.

@philfreo
Copy link
Collaborator Author

philfreo commented Aug 19, 2013

@PaulUithol @DouweM Thoughts on this?

philfreo added 4 commits Jul 10, 2013
Side effect (seems fine to me) is that it also continues to return IDs of deleted models, which
seems less magic and more expected to me - also allows for 'soft deletes' where an object itself
is deleted but other objects can still have references to it.
@philfreo
Copy link
Collaborator Author

philfreo commented Oct 29, 2013

Rebased against latest master.

@PaulUithol
Copy link
Owner

PaulUithol commented Oct 29, 2013

Was on the fence about this one for a bit; but seems quite fine to me. Merging.

PaulUithol added a commit that referenced this pull request Oct 29, 2013
Fix for #375 - toJSON should include IDs of unregistered models
@PaulUithol PaulUithol merged commit 6ae1e60 into PaulUithol:master Oct 29, 2013
@philfreo
Copy link
Collaborator Author

philfreo commented Oct 29, 2013

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.