Fix for #375 - toJSON should include IDs of unregistered models #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PaulUithol @DouweM Thoughts on this? |
…dels Side effect (seems fine to me) is that it also continues to return IDs of deleted models, which seems less magic and more expected to me - also allows for 'soft deletes' where an object itself is deleted but other objects can still have references to it.
|
Rebased against latest master. |
|
Was on the fence about this one for a bit; but seems quite fine to me. Merging. |
PaulUithol
added a commit
that referenced
this pull request
Oct 29, 2013
Fix for #375 - toJSON should include IDs of unregistered models
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #375
Side effect (seems fine to me) is that it also continues to return IDs of deleted models, which
seems less magic and more expected to me - also allows for 'soft deletes' where an object itself
is deleted but other objects can still have references to it.