Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position changer not work #43

Closed
utrobinmv opened this issue Sep 4, 2014 · 5 comments
Closed

Position changer not work #43

utrobinmv opened this issue Sep 4, 2014 · 5 comments

Comments

@utrobinmv
Copy link

Position changer not work

I can't set Position changer, "hours" and "minuts"

@PaulWoitaschek
Copy link
Owner

Hey,
can someone confirm this? I cant see any problems. (this just works within a track, not within the whole book). I mostly made this so people who have a very large audiobook in a single file can change the position fast.

@JoshGraham
Copy link
Contributor

Nothing seems broken in Nexus 7/Moto G
Though...

Oh, position changer is quite intelligent.

It calculates the length of a track, then sets its maximum time(usually minutes), according to individual tracks.

Thus, track 2:59 gets 2 minutes maximum, track 12:59 gets 12 minutes maximum.

If track is 0:59, position changer just stays at 0:0, user can't do anything.
it knows it's less than a minute, thus it put its hand up.
"What do you want me to do, master? Your track is not even 1 minute long!"
..."Hey, you're right."

In the same behavior, if user's track is less than 1 hour long, user can't manipulate hour part of the position changer.

Thus, confusions could stem from,

  1. User might feel it doesn't follow user's orders, thus feel it's broken(not doing its job) - even though it's so intelligent, it does its job well. It just exceeded user's expectations.
  2. User might think position changer can move between tracks in the album.

Both confusion might arise from user's expectation of what "position changer" would do, and what actually it does.

IMHO, There seems to be not a technical issue here, just inherent limitation of communication between humans and machines. They're both right. They just don't speak the same language, thus it might create misunderstanding and confusion.

@PaulWoitaschek
Copy link
Owner

I have an idea. I originally started that function because I have many books containing a single file. That was the reason I started the time chooser. And for tracks that long seconds are useless. When I'll return from my holiday, I'll add seconds as well so there are 3 cases then :
Case 1, track a shorter than 60 secs:
Secs shown
Minutes hidden
Hours hidden
Case 2,track shorter than 60 minutes:
Secs shown
Minutes show
Hours hidden
Case 3, track 60 mins or longer :
Secs hidden
Minutes shown
Hours shown.

Mostly wrote this for myself so I will still remember in 6 weeks :-P

On 4. September 2014 14:52:53 MEZ, JoshGraham notifications@github.com wrote:

Oh, position changer is quite intelligent.

It calculates the length of a track, then sets its maximum time(usually
minutes), according to tracks.

Thus, track 2:59 gets 2 minutes maximum, track 12:59 gets 12 minutes
maximum.

So, in theory, unless user's track is more than 1 hour long, user can't
manipulate hour part of the position changer.

User might get confused about this limitations - even though it's so
intelligent, it does its job well.

But, let me check about a track an hour long... I'm not sure I have it.
Let's see....


Reply to this email directly or view it on GitHub:
#43 (comment)

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@utrobinmv
Copy link
Author

I think it not the best idea. Audiobooks from one file doesn't meet. The book from several files has to be a single whole. Example:
Audiobook 1
File 1 - length 01:10
File 2 - length 10:15
File 3 - length 12:00
Total length of the book 23:25
It is chosen at the beginning of "Position changer" and I am chosen 15 minutes has to pass automatically to "File 3" to a position 3:35
15:00 - (01:10 + 10:15) = 15:00 - 11:25 = 3:35

@PaulWoitaschek
Copy link
Owner

I simplified it as of 4c4d1a9
Since I think it wont be used often, I put it to settings menu. Also if you now click on the played time, the dialog is beeing launched. Also I hid the hours if there are no hours which makes it less confusing. The jumping to a overall position would just make sense to me when coming from some kind of other player, but normally with many tracks you never should be aware of what the cummulated time is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants