Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AuditTrail non-nullable in the data model #486

Closed
2 of 3 tasks
arteymix opened this issue Oct 30, 2022 · 3 comments
Closed
2 of 3 tasks

Make AuditTrail non-nullable in the data model #486

arteymix opened this issue Oct 30, 2022 · 3 comments
Assignees
@arteymix
Labels
enhancement Enhance the code or user experience
Milestone
1.29.0

Comments

@arteymix
Copy link
Member

arteymix commented Oct 30, 2022 •
edited
Loading

This is a general assumption throughout the code, but there's nothing in the database that enforces this non-nullity. It's actually part in the Persister implementation to fill in the audit trail for auditable entities.

  • update AUDIT_TRAIL_FK column to be non-null
  • add non-null to the Hibernate model
  • maybe consider making this field final?
@arteymix arteymix added this to the 1.29.0 milestone Oct 30, 2022
@arteymix arteymix self-assigned this Oct 30, 2022
@arteymix arteymix added the enhancement Enhance the code or user experience label Oct 30, 2022
@arteymix
Copy link
Member Author

Once the 1.29 is out, we'll need to switch the column to non-null in the database. It's already part of the migration script.

@arteymix
Copy link
Member Author

See ea110b3

@arteymix arteymix mentioned this issue Nov 29, 2022
Closed
10 tasks
@arteymix
Copy link
Member Author

arteymix commented Dec 4, 2022

Post-release steps are now in #505.

@arteymix arteymix closed this as completed Dec 4, 2022
@arteymix arteymix mentioned this issue Dec 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arteymix arteymix

Labels
enhancement Enhance the code or user experience
Projects
None yet
Milestone
1.29.0
Development

No branches or pull requests
1 participant
@arteymix